Git Product home page Git Product logo

Comments (5)

ch-sa avatar ch-sa commented on August 18, 2024 1

Hi @Divelix,

thanks for reporting.

Is it really for all shortcuts or specific one?

I am not in reach of my dev machine this week, so can debug earliest next week.

@chingyulin Do you have to time for a quick look/ debug?

from labelcloud.

chingyulin avatar chingyulin commented on August 18, 2024 1

Hi @Divelix,

I was able to reproduce the problem. It seems the event object is on label_list by default. The fix seems to be more involved due to the way we handle key press events. For now, a quick workaround is to press Tab to shift the focus when the shortcut is not working. Could you check if this workaround works for you?

from labelcloud.

Divelix avatar Divelix commented on August 18, 2024

W, A, S, D, X, Y, Q, E, C, V, B, N don't work for sure.

from labelcloud.

Divelix avatar Divelix commented on August 18, 2024

Hi, @chingyulin,

Your workaround with Tab works fine for me, thank you!

from labelcloud.

ch-sa avatar ch-sa commented on August 18, 2024

Hi @Divelix,

the event filter that handles the keyboard shortcuts is currently still a bit hacky.

This is why a focus of the label list has the effect that keyboard events are not considered by the event filter as they have the wrong "origin".

I added the label list to the origins that should be considered and it should work now with branch: ch-sa/fix-event-focus.

@chingyulin thanks for the temporary solution, I added the PR for you to review.

from labelcloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.