Comments (3)
Thanks for the report (and all the details)!
One note about your proposed solution: Enums are integers under the hood, so they default to 0 and cannot be null. In the MyImplicitEnum
case, there's no way for the serializer to tell whether the record property was set to MyEnumOne
or never touched.
The root cause here is the lack of a default case in the generated switch expression. Fortunately, the bug doesn't cause problems with legit enum values that don't have a match; that's checked when the serializer is built. I think the most correct solution would be to add a default case throwing ArgumentOutOfRangeException
for any unnamed enum value.
from dotnet-avro.
Fix released with 5.0.2; also cherry picked into 2.1.1, 3.3.1, and 4.1.1 since it's a data corruption issue.
from dotnet-avro.
Thank you so much, yet again--you're definitely making our lives easier! 😄
from dotnet-avro.
Related Issues (20)
- Unable to generate a schema with default values HOT 2
- Default values support in codegen HOT 5
- `[EnumMember]` value should be used when serializing enum types to `"string"`
- Add support for NodaTime HOT 1
- Could not load file or assembly System.ServiceModel.Primitives.dll HOT 1
- Method not found exception HOT 1
- Union with null and multiple selected types throws exception when serializing null. HOT 1
- Exception serializing an anonymous object HOT 3
- No coercion operator is defined between types 'System.String' and 'System.Char[]'. on a simple string property HOT 8
- Exception when building a serializer for type with a missing field from the schema HOT 2
- Support C# records in codegen HOT 1
- Support DateOnly and TimeOnly types
- JSON test failures under NetCore 3.1
- `ArraySegment<T>` deserialization fails on .NET Framework
- Support for Nullable Uri HOT 1
- Support `IgnoreDataMember` attribute
- Support unsigned number as logical types in codegen from Avro HOT 9
- Change to ConstructValueSubjectName HOT 1
- System.Datetime is not handled consistently HOT 1
- Deserialize string to DateOnly fails on net6 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotnet-avro.