initial issues about adapt-launchnewwindow HOT 11 CLOSED

yep I think you're right

from adapt-launchnewwindow.

don't initialize / do initialize scorm control

Don't worry too much about this yet, I'm more interested in knowing what happens as things stand. Make the other changes then we'll give it a test and see what's what.

from adapt-launchnewwindow.

👍

from adapt-launchnewwindow.

sorted @moloko

i'm not keen on the configModel override, but that's life.

from adapt-launchnewwindow.

i think this should be ready to test? it's got the default text in from the one you sent me, plus the default behaviour from it also.

from adapt-launchnewwindow.

First issue I've found is that it ALWAYS activates, no matter which page you launch from.

So, if you launch the course from index.html the extension kicks in and redirects you to index_lms.html

99% of the time you'd only want this extension to run if launching the course via index_lms.html BUT to cope for the other 1% it would be useful to be able to specify a list of pages that trigger activation

from adapt-launchnewwindow.

Also, there's no need for it to do anything when 'current window' is the required setting. It should just let Adapt run as normal.

from adapt-launchnewwindow.

I think the vast majority of use-cases for this will be 'When run from the LMS I want the course to launch in a new window if the user is running the course on iOS'

from adapt-launchnewwindow.

Another possible use-case: client is launching the course in two different environments:

1. from a web server, where the course is embedded in the page via an iframe
2. from an LMS where the course is displayed in a new window with no iframe/frameset

In that example, I'd want to configure this extension to launch in a new window only when index.html is run on iOS

from adapt-launchnewwindow.

cool

from adapt-launchnewwindow.

we can do all of this now right? @moloko

from adapt-launchnewwindow.