Git Product home page Git Product logo

Comments (8)

Lineflyer avatar Lineflyer commented on June 16, 2024

Can reproduce on Android 9. Fine however on older and newer versions (or it depends on resulution as my Android 9 device is a tablet).

from whereyougo.

Lineflyer avatar Lineflyer commented on June 16, 2024

Tested with PR#67:
Samsung S10, Android 10.

  • Menu color is fine (as it was also before)
  • White text is now also used in other places, where it should not be used (e.g. Caption of about page, Menu entries in map settings, Dir Chooser dialog). See attached screenshots for details.

Screenshot_20200308-112333
Screenshot_20200308-112347
Screenshot_20200308-112833
Screenshot_20200308-112257

from whereyougo.

Lineflyer avatar Lineflyer commented on June 16, 2024

Tested with PR #67:
Android 9, Samsung Galaxy Tab S4 (Tablet)

  • The problem of black menu text is still there
  • Additionally now white text in other parts, where it should not be (same as on Android 10 as posted above).
    Screenshot_20200308-112603
    Screenshot_20200308-112556
    Screenshot_20200308-112648

from whereyougo.

bekuno avatar bekuno commented on June 16, 2024

Yes, I saw it in the same way on older Android versions.
The formatting needs to be completely recreated.
We should let it for now unchanged.

from whereyougo.

Lineflyer avatar Lineflyer commented on June 16, 2024

I had a brief look on older Android versions:
Basically the same. The menu text mentioned in your inital post is unchanged, but other parts, which should not have white text, got white text.

I agree. Lets leave PR#67 out for now and come back to this problem a bit later. Its mainly cosmetic and the whole thing needs rework.

from whereyougo.

andrixnet avatar andrixnet commented on June 16, 2024

I've just joined the WhereYouGo beta testers :-)
Thank you for reviving this app.

I can confirm this issue on Samsung S9+ / Android 9

from whereyougo.

RickyTUM avatar RickyTUM commented on June 16, 2024

When I make the following change to the file:
src/main/res/values/styles_theme.xml
the menu looks good on Android 7 and 9.

<style name="AppTheme" parent="@android:style/Theme.Light.NoTitleBar">

change to:

<style name="AppTheme" parent="android:Theme.DeviceDefault.Dialog.NoActionBar">

from whereyougo.

bekuno avatar bekuno commented on June 16, 2024

@RickyTUM
Thanks for finding a possible solution.
Please create a PR, if possible.
If you have any questions, take a look at the c:geo wiki (adopt it for WhereYouGo) and do not hesitate to ask them.

from whereyougo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.