Comments (8)
Can reproduce on Android 9. Fine however on older and newer versions (or it depends on resulution as my Android 9 device is a tablet).
from whereyougo.
Tested with PR#67:
Samsung S10, Android 10.
- Menu color is fine (as it was also before)
- White text is now also used in other places, where it should not be used (e.g. Caption of about page, Menu entries in map settings, Dir Chooser dialog). See attached screenshots for details.
from whereyougo.
Tested with PR #67:
Android 9, Samsung Galaxy Tab S4 (Tablet)
- The problem of black menu text is still there
- Additionally now white text in other parts, where it should not be (same as on Android 10 as posted above).
from whereyougo.
Yes, I saw it in the same way on older Android versions.
The formatting needs to be completely recreated.
We should let it for now unchanged.
from whereyougo.
I had a brief look on older Android versions:
Basically the same. The menu text mentioned in your inital post is unchanged, but other parts, which should not have white text, got white text.
I agree. Lets leave PR#67 out for now and come back to this problem a bit later. Its mainly cosmetic and the whole thing needs rework.
from whereyougo.
I've just joined the WhereYouGo beta testers :-)
Thank you for reviving this app.
I can confirm this issue on Samsung S9+ / Android 9
from whereyougo.
When I make the following change to the file:
src/main/res/values/styles_theme.xml
the menu looks good on Android 7 and 9.
<style name="AppTheme" parent="@android:style/Theme.Light.NoTitleBar">
change to:
<style name="AppTheme" parent="android:Theme.DeviceDefault.Dialog.NoActionBar">
from whereyougo.
@RickyTUM
Thanks for finding a possible solution.
Please create a PR, if possible.
If you have any questions, take a look at the c:geo wiki (adopt it for WhereYouGo) and do not hesitate to ask them.
from whereyougo.
Related Issues (20)
- Changing storage folder does not update Settings activity HOT 1
- Menu items too dark HOT 1
- Add Mapsforge map v4/5 support HOT 1
- Longitude is shown as latitude HOT 5
- Can't see *.gwc files in the directory HOT 12
- Locus Maps Classic cannot be selected HOT 1
- Fail to download cartridge HOT 2
- Raise targetSDK to 31
- Most important issues to be fixed HOT 2
- using `AccuracyVer`
- remove posibility to change WhereYouGo folder for newer devices HOT 1
- Next release
- CI shows many lint problems
- Make text copyable
- Cant download or import cartriges HOT 5
- Crash when checking login data HOT 1
- Dialog WebView's scroll position lost after rotation
- No where I go cartridge available HOT 2
- Can't change whereigo directory in whereyougo app HOT 5
- switch to compileSdk & targetSdk 33
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whereyougo.