Git Product home page Git Product logo

Comments (6)

cgarvis avatar cgarvis commented on June 13, 2024

Not not aware of what form.$pristine is but it may have to do with ngModel which is something I would like to support. #31 has this implemented, so I hope to have it in soon.

from angular-toggle-switch.

ssmereka avatar ssmereka commented on June 13, 2024

Angular.js Docs: Form Controller

A form is pristine when a user has not yet interacted with it. If a user toggles the angular-toggle-switch in a form, then form should be set to $dirty. This would be really easy to handle outside of your library using ng-click.

However you have ng-click automatically overridden to be "toggle()". If someone adds ng-click to the toggle-switch like so:

<toggle-switch model="myModel" ng-click="doSomething()"></toggle-switch>

The result will be something like this:

<div class="form-toggle-switch switch ng-isolate-scope" ng-click="doSomething() toggle()" name="activatedSwitch" model="myModel">

As you can see ng-click no longer works because ng-click="doSomething() toggle()" is invalid.

from angular-toggle-switch.

cgarvis avatar cgarvis commented on June 13, 2024

@ssmereka should bind to the element's onClick natively then?

from angular-toggle-switch.

ssmereka avatar ssmereka commented on June 13, 2024

Sorry if I don't entirely understand what you mean by bind onClick natively.

If you mean everything that is in ng-click for the tag "toggle-switch" will appear exactly the same way in generated "div" tag's ng-click. Then yes that would be a great solution.

from angular-toggle-switch.

cgarvis avatar cgarvis commented on June 13, 2024

This should be fixed on master

from angular-toggle-switch.

ravisr avatar ravisr commented on June 13, 2024

How do we update the status to ON/OFF based on the status that we get from API?

from angular-toggle-switch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.