Git Product home page Git Product logo

Comments (9)

higs4281 avatar higs4281 commented on June 11, 2024

thanks. i want to get some browser tests and js tests running before we
deploy.

On Tue, May 19, 2015 at 4:05 PM, Orlando [email protected] wrote:

I see lots of good stuff going on in here,, feel free to ask me or the
software delivery team if you need help setting up browser, API,
performance tests, we're more than glad to help you get started :)

We'll start setting up BDD security testing for this project soon.


Reply to this email directly or view it on GitHub
#13.

from retirement.

imuchnik avatar imuchnik commented on June 11, 2024

Would be happy to help. Word of caution: Often to get js tests going, code may need to be refactored. So keep that in mind when estimating.
I am going to volunteer @contolini for this as well.

from retirement.

OrlandoSoto avatar OrlandoSoto commented on June 11, 2024

@higs4281 where's the front end for this project? is it possible to get a localhost instance going on my mac?

from retirement.

higs4281 avatar higs4281 commented on June 11, 2024

it's a self-contained one-page app; page is in retirement_api/templates.
local resources are in retirement_api/static. it's intended to run inside consumerfinance.gov, so we use site resources as well that won't work stand-alone.

from retirement.

OrlandoSoto avatar OrlandoSoto commented on June 11, 2024

ok, one thing that would be extremely helpful is to use unique ID's for elements that the user will interact with,, similar to what you did with the retirement age selector in step 3:

{% trans "Choose age" %} 62 63 64 65 66 67 68 69 70

from retirement.

imuchnik avatar imuchnik commented on June 11, 2024

@Ooblioob @higs4281 @mistergone

We should really not deploy without testing. The bare essentials for front end (unit) testing are:

  1. testing framework
  2. Code coverage tool
    Lets talk about it some time next week to see if we can get these things worked out.
    Perhaps a front end code review with myself and @contolini to make sure we are not creating another "snowflake"

from retirement.

contolini avatar contolini commented on June 11, 2024

The front-end's logic has grown complex. A small amount of refactoring would allow unit tests to be written for it. Shoot me an email if you'd like some help with this.

from retirement.

mistergone avatar mistergone commented on June 11, 2024

I'm all ears. I'm also booked solid for a week or so. That said, I'm pretty good with writing unit-testable code, but I need some guidance on what our current tools are and how we're working them.

I ain't afraid of no tests.

from retirement.

imuchnik avatar imuchnik commented on June 11, 2024

@mistergone Great! Schedule a time most convenient to you. In the mean time, @contolini and I can do a code review and make refactoring suggestions. To start, can we change the file structure, so that javascript code is not buried inside api directory and not add more code into one giant file?

Let me know what you think

from retirement.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.