Playlists capped at 50 about spotui HOT 9 CLOSED

@diegoulloao took a couple hours today and cranked it out for you. will be coming soon, available at octoshrimpy@6684f4b

from spotui.

Great man!!! you're the best, I use spotui every day at work. Thank you man, waiting for the release :)

from spotui.

Sigh, I've just realised you can't see any of my change request comments because I'm now the author of the PR and authors can't request changes on their own PRs 🤦

Would you be able to re-create all 3 PRs? I'll close the current ones, that way I can be assigned as the reviewer. What a nightmare

Edit: nevermind, sorted - you should be able to see them now

from spotui.

I'm also up for helping convert from barebones curses to blessings

from spotui.

Hey,

The playlist issue is due to there being a limit of 50 items on the playlist endpoint and I don't bother fetching the additional ones after the first request. Should be a simple fix (I'll track that using this issue).

On the other stuff you mentioned: User themes would be a nice feature and would be pretty trivial to implement. Autoscrolling truncated text is a cool idea too. Not too sure about rewriting the UI as curses isn't causing any issues currently to my knowledge.

If you do fancy contributing I'll create issues for the above 2 with a brief guide on implementation. Feel free to raise a PR for one/both of them - (and thanks 🙂 )

Edit: see #22 and #23 :)

from spotui.

Is this resolved?

from spotui.

no, not yet. I'm thinking if the API doesn't tell us how many songs there are total, the just query the api for the next "page" until the results are less than 50.
I'm currently busy with another project, so I can't crank time into this quite yet.

from spotui.

@octoshrimpy Just in case you miss the comment on your PR:

I've split out the playlist stuff into a separate PR (#27) as this might take a while to get merged and I know @diegoulloao is waiting for the fix :) This way we can deal with that one separately - looks fine subject to a quick test (see my comment)

I've also split up the rest of the commits into two sections:

#29 General improvements
#28 Theme support (and config improvements)

I've invited you as a collaborator to the repo so you should be able to make changes to these new PRs

from spotui.

sounds good!
I'll go through those PRs and clean up any unnecessary code that I may have left (PR was submitted rather late at night haha). For now, test #27 for first merge, and then #28 next?

from spotui.