Comments (3)
@jcorporation Jürgen, can you please check #2720 ? (In both scenarios) Thank you !
It's a pleasure for me to confirm that this patch fixes both scenarios!
from mongoose.
@jcorporation Jürgen, can you please check #2720 ? (In both scenarios) Thank you !
@cpq : I think we've been going back and forth with two corner cases. Using "blame" I can see we've been using mg_tls_pending()
, then resorted to c->rtls.len
and then back to mg_tls_pending()
.
I think there are two corner cases here:
- Msg is very short and gets sent along with the headers.
mg_tls_pending()
returns 0 as it has no data, BUTc->rtls.len > 0
as there is outstanding data after parsing headers. That is #2603 , we fixed it but broke the next scenario - Msg is of such a length that a whole block, or a group of them, fit the transfer.
c->rtls.len
is zero, BUTmg_tls_pending()
will indicate it has a block to process. That seems to be #2619, its fix goes back to how things were before, causing a regression on the former scenario.
I merged both, and IIRC we've been there before, I remember some chat when we discussed whether both were necessary or not. I think this is real life answering us both.
from mongoose.
@scaprile thank you Sergio, makes sense!
from mongoose.
Related Issues (20)
- MacOS unit tests fail with MbedTLS HOT 9
- Is it possible to add the mg_mqtt_unsub function? HOT 3
- mqtt: Unable to set zero-length Will message
- how can we access fn_data from mg_http_listen's callback funtion (mg_event_handler_t) ? HOT 3
- [Request feature] can you support wolfssl library HOT 3
- upload in https using examplefile-upload-html-form is always pending in chrome but is ok in firefox. HOT 1
- Socket error after ota-updating the filesystem image HOT 1
- Cleanup string API HOT 5
- mongoose.c:7543:accept_conn 1 accept failed, errno 24 HOT 1
- mg_http_next_multipart bug HOT 3
- cannot connect MQTT to STM32F407 HOT 1
- When I used the TLS scanning tool (https://github.com/rbsec/sslscan, scanning command: sslscan --tlsall 127.0.0.1:8443) to scan the 8443 port of the mongoose examples http-restful-server, the program appeared Infinite loop, continuous log printing, even if I have ended the TLS scan command. HOT 2
- The "mg_url_host" function is not work? HOT 1
- Can FreeRTOS_IPInit_Multi function be used properly? HOT 3
- Wrong assets in 7.14 HOT 1
- Mongoose accepts HTTP requests with invalid versions HOT 6
- Mongoose accepts requests containing multiple differing Content-Length headers. HOT 7
- Mongoose ignores `Connection: close` headers HOT 1
- Potential Memory Leak in `mg_timer_free` Function HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongoose.