Magic Items To Do List about dndappfiles HOT 18 CLOSED

Mask of the Dragon Queen wasn't included. I've added it in my forked file.

from dndappfiles.

You'll need to submit a pull request
On Sat, Apr 4, 2015 at 12:26 PM LoreMasterRoth [email protected]
wrote:

Mask of the Dragon Queen wasn't included. I've added it in my forked file.

—
Reply to this email directly or view it on GitHub
#12 (comment).

from dndappfiles.

Done. Also the HotDQ items were already done when I began.

from dndappfiles.

I never got your pull request, you sure you sent one?

On Sat, Apr 4, 2015 at 12:32 PM LoreMasterRoth [email protected]
wrote:

Done. Also the HotDQ items were already done when I began.

—
Reply to this email directly or view it on GitHub
#12 (comment).

from dndappfiles.

I'm new to GitHub, do I assign it to you? I'm coding the Dragon masks now.

from dndappfiles.

Are you using the Mac/PC app?

On Sat, Apr 4, 2015 at 12:48 PM LoreMasterRoth [email protected]
wrote:

I'm new to GitHub, do I assign it to you? I'm coding the Dragon masks now.

—
Reply to this email directly or view it on GitHub
#12 (comment).

from dndappfiles.

I'm currently working out of the chrome browser.

from dndappfiles.

Okay, what you need to do is go to the top right and click where it says fork, and then make any changes you want to make to a file, and then there should be an option to submit a pull request.

Whenever you decide to work on adding something new make sure your fork is up to date.

from dndappfiles.

I'm not sure if I did it right. Bear with me. The master file now includes the new info I added.

from dndappfiles.

Okay, now you need to create the pull. Try this link:
https://github.com/ceryliae/DnDAppFiles/compare

from dndappfiles.

It looks like I collapsed it before comparing. I think I just directly updated the master and erased the fork. Take a look at the file. The last entry now should be the Dragontooth Dagger.

from dndappfiles.

I'll not make that mistake again... hopefully.

from dndappfiles.

I never got a pull request from you

from dndappfiles.

Apparently it can be done without submitting one. I don't know what to say. I'm not really sure what order of operations I used.

I'm really just trying to help. I'll do it right next time.

from dndappfiles.

Alright, don't worry about it. You just forgot to make the pull request,
you did everything else okay.

from dndappfiles.

Ok, this is where I got stuck last time. I have the file in my forked directory. How do I find it in the Compare changes?

from dndappfiles.

I can list the PoA items if need be.

from dndappfiles.

Please do

from dndappfiles.