Git Product home page Git Product logo

Comments (5)

ProbstDJakob avatar ProbstDJakob commented on May 28, 2024 3

I think ClusterBundle is still a better name since it does not belong to a single namespace. Furthermore this would allow adding a Bundle CRD which is bound to a namespace later. Much like ClusterIssure and Issuer. (See also #131 (comment))

from trust-manager.

jetstack-bot avatar jetstack-bot commented on May 28, 2024 1

@erikgb: You must be a member of the cert-manager/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone trust-manager v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from trust-manager.

SgtCoDFish avatar SgtCoDFish commented on May 28, 2024 1

(Added to milestone, annoying that there's another group for it!)

FWIW I agree about Bundle / ClusterBundle now. I see the use case and I think it's worth renaming the resource we currently have to ClusterBundle. I also see the value in adding Bundle as a namespace-scoped resource, but I'm currently inclined to think we don't need to do both things at once.

I suspect we'll make the rename from Bundle -> ClusterBundle in v1alpha2 or v1beta1, which is on the roadmap after us hearing so much demand for trust-manager v1 at KubeCon NA in Chicago!

from trust-manager.

SgtCoDFish avatar SgtCoDFish commented on May 28, 2024

Agree with ClusterBundle being a better match for current behaviour, although IIRC from past conversations amongst the maintainer team I've made the case for us to change Bundle to default to only write the target in a single namespace, with the option to write to all.

In any case, I think the behaviour of writing to all namespaces shouldn't be the default and I feel like Bundle would fit pretty well in that case. What do you think?

(Thank you for your contribution!)


EDIT: See #39 which I actually raised about changing the behaviour!

from trust-manager.

erikgb avatar erikgb commented on May 28, 2024

/milestone trust-manager v1

from trust-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.