Comments (7)
@hawksight At least the CRD installation can be optimized. At the moment, CRDs are applied as manifests by HELM.
There is an option to put CRD definitions into a special subdirectory crds
. This allows the user to skip the CRD installation using HELM's command line flag. In addition to that, HELM will not fail if the CRDs are already available.
This can be the case if you install all CRDs for your cluster manually before installing HELM chart releases.
A possible use case is the Terraform Kubernetes Provider which requires that supported CRDs must be available before execution.
AFAICS, moving the CRD definition to the crds
directory should be enough.
from trust-manager.
That worked around it for me! Thanks so much.
from trust-manager.
Hey @earlgrey88 - I think with v0.2.0 this is solved and is now available as an input: https://github.com/cert-manager/trust-manager/blob/main/deploy/charts/trust-manager/values.yaml#L4-L5
Also the CRD does install as part of that version of the chart (or it did for me :) )
So we can probably close this one?
from trust-manager.
I came here looking for a way to install the Bundle CRD separately from the trust-manager chart. I want to make trust-manager a subchart dependency of my application, but Helm will not install the subchart first to satisfy the CRD requirement of my chart, so I need to peel off the /crds
in advance, then install my chart which depends on trust-manager. This is how it works with cert-manager.
from trust-manager.
Thanks @bephinix & @qrkourier for the notes. Just taking a look at #102 it seems that the CRDs are now optional through the values options, see here. Released in v0.4.0
So the CRDs are now installed automatically for a default helm installation, but can be disabled. That seems like it resolves the initial issue's request.
I don't think it's exactly the way that the helm docs suggest, but it is similar to cert-manager's configuration.
So an install without CRDs can be applied with:
# Assuming repo is added and up to date
helm template -n cert-manager jetstack/trust-manager --set crds.enabled=false
And applying the CRDs manually can be done with:
k apply -f https://raw.githubusercontent.com/cert-manager/trust-manager/v0.4.0/deploy/crds/trust.cert-manager.io_bundles.yaml
Does that help your use case @qrkourier with the sub chart or not? If it doesn't I'd suggest we open a separate issue for that use case.
from trust-manager.
I think this issue can be closed. The support for image pull secrets was introduced in #15. For the CRDs, cert-manager projects have implemented another approach for Helm: https://cert-manager.io/docs/installation/helm/#helm-installation. That Helm lacks proper support for CRDs is well-known, and I think the cert-manager approach is by far the least evil solution to this problem.
from trust-manager.
Closing as per @erikgb 's comment - thanks all!
from trust-manager.
Related Issues (20)
- Issue with CRDs when having trust-manager as chart dependency
- No flag to set structured logging format, e.g. JSON? HOT 2
- Using `trust-manager` for generating keystores HOT 5
- Evaluate trust namespace value as template
- Init Container cert-manager-package-debian Helm Chart should allow resource requests and limits HOT 1
- Bundle generating empty truststore.p12 when no password is provided HOT 2
- Allow all resources to be namespaced
- trust-manager deduplication doesnt work HOT 12
- Add support to s390x arch HOT 9
- Add support for kubectl installation HOT 3
- Add matchExpressions to Bundle's spec.target.namespaceSelector HOT 3
- Avoid multiple decode/encode of certificates HOT 6
- Provide deterministic bundle HOT 5
- Wrong labels in topologySpreadConstraints example in the Helm chart values
- Chart is not allowing to pass Certificate Issuer name through value.yaml
- Document a policy around immutable image tags HOT 1
- Support RSA Keys HOT 3
- Helm chart support dual stack clusters
- Allow to specify admission webhooks CA from Bundle HOT 3
- Empty Target field in kubectl get bundle HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trust-manager.