Git Product home page Git Product logo

Comments (7)

mhemesath avatar mhemesath commented on September 24, 2024

If the route to mount a content provider is protected by some other means, such as OAuth header validation, there is no need to challenge the consumer for a secret.

Technically all our apps are protected by other means... The question is once the content has been loaded, if I navigate away and go to a malicious site, are they able to to embed this app? How are you preventing that from happening?

from xfc.

poloka avatar poloka commented on September 24, 2024

If the initial page loads and authorizes itself to be displayed, how would the existing consumer challenge eliminate the ability to navigate to other page within that iFramed window?

from xfc.

poloka avatar poloka commented on September 24, 2024

Talked through with @slor on idea as well. If the challenge is not provided that any consumer would be able to embed the content of the document served by the provider; however, in this case the document is not even served if the cloud oauth validation (server side) does not succeed. So for a content provider to ignore the challenge could open themselves up to click-jacking only if they do not protect them in some other secure fashion. Maybe that was more of the question being asked.

from xfc.

poloka avatar poloka commented on September 24, 2024

@whitehatguy, thinking through this security idea, wanted to get your thoughts to if we're opening any holes?

from xfc.

poloka avatar poloka commented on September 24, 2024

To add a bit more information, what we have discovered is that the communications across the iframe are delayed and sporadic. I've seen the challengeConsumer take anywheres from ~100 ms to upwards of 5+ seconds. Only speculating but possible because of the event loop restrictions within the client consumer. Looking for ways to improve the performance.

from xfc.

mhemesath avatar mhemesath commented on September 24, 2024

FWIW this.authorizeConsumer() is a public method you can call yourself. Though I recommend against it cause I'm not confident you're preventing any UI redress attacks.

from xfc.

kafkahw avatar kafkahw commented on September 24, 2024

Fixed in #12

from xfc.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.