Git Product home page Git Product logo

Comments (6)

mpatrascoiu avatar mpatrascoiu commented on July 21, 2024

Hello,

It's unclear whether they were removed by accident or not.
In a separate PullRequest (#79) we decided not to bring them back.

The direction in the other Data Management Clients (DMC) projects was to move away from CTest.
I will close the ticket.

Cheers,
Mihai

from davix.

amadio avatar amadio commented on July 21, 2024

Could you please clarify this with @gbitzes, then? It seems that many tests that were run before are no longer running. For me, the slow unit tests now cause a segmentation fault (see below). Tests in test/bench also fail if I try to run them. Shouldn't these be run in CI, even if not anymore via CTest? Since there have been major changes after the last release (0.7.6), I want to wait until the reason for these test failures is understood before updating davix in Gentoo Linux (where I maintain its package).

$ test/slow-unit/davix-slow-unit-tests 
Running main() from gtest_main.cc
[==========] Running 10 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from DrunkServer
[ RUN      ] DrunkServer.NoClients
[       OK ] DrunkServer.NoClients (1000 ms)
[ RUN      ] DrunkServer.ClientInteraction
[       OK ] DrunkServer.ClientInteraction (1 ms)
[----------] 2 tests from DrunkServer (1001 ms total)

[----------] 4 tests from Standalone_Neon_Request
[ RUN      ] Standalone_Neon_Request.BasicSanity
CONSUMED: GET /chickens HTTP/1.1

CONSUMED: User-Agent: libdavix/0.8.0.1.5cf6c6d6.dirty neon/0.0.29

CONSUMED: Keep-Alive: 

CONSUMED: Connection: Keep-Alive

CONSUMED: TE: trailers

CONSUMED: Host: localhost:22222

CONSUMED: I like: Turtles

CONSUMED: 

WRITING RESPONSE
Response written successfully
[       OK ] Standalone_Neon_Request.BasicSanity (1001 ms)
[ RUN      ] Standalone_Neon_Request.Redirect
CONSUMED: GET /test HTTP/1.1

CONSUMED: User-Agent: libdavix/0.8.0.1.5cf6c6d6.dirty neon/0.0.29

CONSUMED: Keep-Alive: 

CONSUMED: Connection: Keep-Alive

CONSUMED: TE: trailers

CONSUMED: Host: localhost:22222

CONSUMED: 

WRITING RESPONSE
Response written successfully
[       OK ] Standalone_Neon_Request.Redirect (1 ms)
[ RUN      ] Standalone_Neon_Request.NetworkError
[       OK ] Standalone_Neon_Request.NetworkError (0 ms)
[ RUN      ] Standalone_Neon_Request.StopNoStart
[       OK ] Standalone_Neon_Request.StopNoStart (0 ms)
[----------] 4 tests from Standalone_Neon_Request (1002 ms total)

[----------] 4 tests from Standalone_Curl_Request
[ RUN      ] Standalone_Curl_Request.BasicSanity
Segmentation fault (core dumped)

from davix.

mpatrascoiu avatar mpatrascoiu commented on July 21, 2024

Hello,

OK, let's revive this ticket and we can look into it.
Due to other engagements, unfortunately this will not be very soon.

Cheers,
Mihai

from davix.

amadio avatar amadio commented on July 21, 2024

The question about FindDavix.cmake reminded me of this issue. Has there been any progress on this?

from davix.

mpatrascoiu avatar mpatrascoiu commented on July 21, 2024

Hello,

Unfortunately, no progress here due to other commitments.

from davix.

mpatrascoiu avatar mpatrascoiu commented on July 21, 2024

In #99 , CTest was reintroduced. Ultimately, I think there's no harm to have it available, especially given our CMake files call add_test(..).

However, what we moved away from is running the tests in the rpmbuild during the %check section. All testing should be run in the gitlab-CI testing stage and not during the build stage.

Next step would be to solve the issues around davix-slow-unit-tests and then add it to the davix-tests package.

from davix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.