Git Product home page Git Product logo

Comments (8)

charithe avatar charithe commented on May 14, 2024

https://github.com/vitessio/arewefastyet

from cerbos.

isdevx avatar isdevx commented on May 14, 2024

It seems like https://github.com/rhysd/github-action-benchmark showed some pulse recently. I tested the benchmarks on my own fork and was able to run it. I wonder if we should add this right away as it's pretty straightforward to add. We can experiment it for a while if it makes sense. cc @charithe

from cerbos.

charithe avatar charithe commented on May 14, 2024

SGTM. If they have fixed the issue with parsing Go benchmark suites, it would be good to incorporate it into the PR workflow.

from cerbos.

isdevx avatar isdevx commented on May 14, 2024

Oh that escaped from me 🤦 Nonetheless, I forked the action and used a fork that includes the fix for parsing issue. Now I pointed to custom version and it works fine. We can go with that version until it gets fixed on the upstream.

from cerbos.

charithe avatar charithe commented on May 14, 2024

Are they open to accepting a PR to fix the issue? I would prefer to use the "official" action if possible.

from cerbos.

isdevx avatar isdevx commented on May 14, 2024

There is already a PR for the issue benchmark-action/github-action-benchmark#32 and I forked that fork. I'd say they are open for contributions but there are many to review and consolidate. While waiting for the resolution, we can start using and experimenting the action. The transition between official action and my fork is one line change.

from cerbos.

charithe avatar charithe commented on May 14, 2024

That PR has been open for over a year so it's unlikely that it will get merged soon. I wonder whether there are other alternatives -- even a more actively maintained fork of this one -- that we can use.

Our own fork should be the last resort. If we do decide to do it, let's fork it to the cerbos org.

from cerbos.

charithe avatar charithe commented on May 14, 2024

https://bencher.dev

from cerbos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.