Add pkg mgmt vgo and research about implementation/use in go-ceph about go-ceph HOT 9 CLOSED

@isi-lincoln dep has been the preferred dependency management tool for the last few years. I've used it myself, and have nothing against it. But with Go 1.11 support for modules, it is more likely that vgo with modules will be the path forward.

from go-ceph.

Does this offer an advantage of running go get ./... to grab the dependencies?

from go-ceph.

@noahdesu thx for reply. 💘

What i mean by this issue is that we need a pkg manag. tool for the library the project is using. ( i added go dep) in the PR referenced.

This will not fix completely the failure or enabling test locally because i get other errors of missing pkg devel.

cephfs/cephfs.go:7:10: fatal error: cephfs/libcephfs.h: No such file or directory
 #include <cephfs/libcephfs.h>

( this i got fixed my adding the headers)

Having a pkg mgmt tool enable us to have a good versioning of pkg/lib used in this project.

( i will try to contribute more also on the binding, at moment i am learning ceph :smiley, thx for the lib!)

from go-ceph.

@noahdesu i will have a look for vgo.

from go-ceph.

Thanks @MalloZup. I'll also look at vgo and get up to speed on what's happening in that space. I'm all for adopting new tools and techniques for the project. Were you using ceph-go in a way that made compatibility with different version a problem? Maybe we can address a few specific cases without vendoring everything.

from go-ceph.

I'd offer up a contrary package management tool dep: https://github.com/golang/dep

My own experience is that dep is taking over as the go dependency package manager.

from go-ceph.

@isi-lincoln yop agree with @dswarbrick.there is also the announcement upstream in golang

from go-ceph.

Thank you everyone for chiming in. I've found myself maintaining go-ceph, but I don't use Go or go-ceph on a day to day basis :) so this input is really valuable.

It sounds like in the short term everyone can benefit from tagged releases, and I can make that happen. Further, sometime in the future vgo will be used, but there is nothing to do w.r.t. to vgo / dep at this moment?

from go-ceph.

@noahdesu i think yop is not worth for the moment to use go dep. At moment you are using mainly the testing library.

I think that the vgo is really imminent https://golang.org/dl/ already released the 1.11 so one could already try to do the thing. ( in distro world i would need to check which version is supported)

from go-ceph.