Git Product home page Git Product logo

Comments (4)

leseb avatar leseb commented on July 17, 2024

@Ulexus yes it's a restricted set but using several variables for each type might be really lengthy and will provide the exact same thing. Type are not going to change anytime soon, I don't think new type will come up either BUT having a single variable will be more flexible.
Thus we give the freedom to the users to build their own location.

If we go with CRUSH_ROOT, CRUSH_REGION, CRUSH_DATACENTER etc etc we will have an entrypoint like this:

root=$CRUSH_ROOT region=$CRUSH_REGION datacenter=$CRUSH_DATACENTER host=$(hostname).

In the situation where region is not (simply not required by the operator) set we have to come up with a default value to not this will also add unnecessary complexity to the crush map.
We could also have a set of if statements to check if the variable is empty or not and if so remove it from the command line. But we agree that's a terrible solution.

That's why I prefer to use:

CRUSH_LOCATION='root=default datacenter=dc1 room=1 rack=10 host=$(hostname)'

This will let the user decide and will remove complex solutions in the entrypoint.
It can even be as simple as that:

CRUSH_LOCATION='root=default host=$(hostname)', and this will likely be the default for the CRUSH_LOCATION variable.

from ceph-container.

Ulexus avatar Ulexus commented on July 17, 2024

@leseb I don't know what I was thinking. If the user can read enough to get the environment variable names, they can read enough to get the list of options. Yes, the free-form CRUSH_LOCATION makes much more sense.

from ceph-container.

tangzhankun avatar tangzhankun commented on July 17, 2024

hi @leseb,
I think put all bucket type and value in a CRUSH_LOCATION is good.
And here I have a question on the use case of ceph/daemon:
what's the goal of ceph/daemon? A unified docker images for all daemons?

from ceph-container.

leseb avatar leseb commented on July 17, 2024

@tangzhankun the ceph/daemon contains all the Ceph daemons, it just allows you to enable the one you want. You can only run one daemon per container. If you want a container with all the daemons running you should look at ceph/demo.

from ceph-container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.