Git Product home page Git Product logo

Comments (16)

SebastianVassiliou-cnic avatar SebastianVassiliou-cnic commented on August 14, 2024

The link generation is up to WHMCS, so if the link does not work, then it means you have a WHMCS configuration that is not compatible with your web server. See WHMCS General Settings -> Friendly URLs.

from rtldev-middleware-whmcs-ssl.

jsjcjsjc avatar jsjcjsjc commented on August 14, 2024

Thanks for your kind help, you mean i should talk with Lagom(the WHMCS theme)?
because it only happend in Lagom

from rtldev-middleware-whmcs-ssl.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 14, 2024

@jsjcjsjc if it works with other templates, but not with Lagom - yes, that sounds like the best idea to reach out to them. Feel free to refer to this github issue.

from rtldev-middleware-whmcs-ssl.

jsjcjsjc avatar jsjcjsjc commented on August 14, 2024

@jsjcjsjc if it works with other templates, but not with Lagom - yes, that sounds like the best idea to reach out to them. Feel free to refer to this github issue.

Thanks for your reply.
I tested again in 8.51, it looks like the Links generated by SSL mudole is not correct. it should be end with "xxxxxxx/cart.php?a=add&pid=x"
cloud you please help me with it ?
xP2yMF.jpg

from rtldev-middleware-whmcs-ssl.

h9k avatar h9k commented on August 14, 2024

I understand. It seems that our module should take into account what Friendly URL setting is present in WHMCS.
Will investigate...

from rtldev-middleware-whmcs-ssl.

SebastianVassiliou-cnic avatar SebastianVassiliou-cnic commented on August 14, 2024

Ok so I checked, and actually our module does not even create slugs for the products.
The reason the link is generated that way is from WHMCS.
If that link does not work, it means you configured your WHMCS incorrectly.
Check the General Settings > Friendly URLs setting. It is probably on Full Friendly Rewrite mode. Change that to Basic URLs and you will get the basic url.
Alternatively, just delete the slug from the product.

from rtldev-middleware-whmcs-ssl.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 14, 2024

Sebastian asked me to close this ticket again as it has been processed.
We'll be working on the missing slug generation asap.

from rtldev-middleware-whmcs-ssl.

jsjcjsjc avatar jsjcjsjc commented on August 14, 2024

Thanks for your kind help, I tried in my side.
it looks like good , but after refresh the products page("xxxxxxx/index.php/store/ssl-certificates" ).
the Direct Shopping Cart Link will be changed from "xxxxxxx/cart.php?a=add&pid=x" to "xxxxxxx/index.php?rp=/store/ssl-certificates/secure-site"

cloud you please help me to check it ?

from rtldev-middleware-whmcs-ssl.

h9k avatar h9k commented on August 14, 2024

If the product has a slug, this is how WHMCS generates the link. If there is no slug, it will use the cart.php.
If the link does not work you should contact WHMCS support.

from rtldev-middleware-whmcs-ssl.

jsjcjsjc avatar jsjcjsjc commented on August 14, 2024

If the product has a slug, this is how WHMCS generates the link. If there is no slug, it will use the cart.php. If the link does not work you should contact WHMCS support.

Hi H9k
Thanks for your reply.
I created a new WHMCS 8.51 (in Cpanel) without any third party modules,only whmcs-rrpproxy-registrar 1.7 and whmcs-cnic-ssl.

  1. after sync, it looks good
    xAPJzR.jpg
  2. but after refresh the SSL products page
    xAP8JJ.jpg
  3. the products link changed
    xAPGW9.jpg

cloud you please try it in your side ? I do not think i should talk with WHMCS first.
Thanks

from rtldev-middleware-whmcs-ssl.

jsjcjsjc avatar jsjcjsjc commented on August 14, 2024

I can share my WHMCS admin to you if necessary

from rtldev-middleware-whmcs-ssl.

SebastianVassiliou-cnic avatar SebastianVassiliou-cnic commented on August 14, 2024

No need. It works as designed. See https://docs.whmcs.com/Friendly_URLs
If the URL does not work, then contact WHMCS support. As I already said, WHMCS generates the URLs, not our module.

from rtldev-middleware-whmcs-ssl.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 14, 2024

The mentioned missing Product Slug Generator has been added in v11.0.2.

from rtldev-middleware-whmcs-ssl.

jsjcjsjc avatar jsjcjsjc commented on August 14, 2024

The mentioned missing Product Slug Generator has been added in v11.0.2.

Thanks for your update
after click "import 23 products" ,it will display error below

 Error! SQLSTATE[42S02]: Base table or view not found: 1146 Table 'gonamec1_hostu.tblproducts_slugs' doesn't exist (SQL: select exists(select * from `tblproducts_slugs` where `product_id` != 1 and `slug` = secure-site) as `exists`)

it only happend in WHMCS 8.13, WHMCS 8.51 is good

OS: windows 11
Browser Microsoft Edge 105.0.1343.42
WHMCS Version 8.13 & 8.51
PHP Version 7.4
SSL Module Version 11.02
RRP Module Version 1.7

1111111.jpg

from rtldev-middleware-whmcs-ssl.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 14, 2024

Thanks @jsjcjsjc for the follow-up and addressing this. Will be reviewed/improved asap.

from rtldev-middleware-whmcs-ssl.

KaiSchwarz-cnic avatar KaiSchwarz-cnic commented on August 14, 2024

v11.0.3 is patching this issue for older versions.

from rtldev-middleware-whmcs-ssl.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.