v055e: packet capture to file broken about rethink-app HOT 8 CLOSED

• Can you confirm whether both Downloads folder & Logcat did not work?

The 'Logcat' option seems to work fine. The 'Downloads folder' option creates a file successfully - the file just isn't correctly formatted.

• For Downloads folder, make sure Rethink has been granted access to write to the external storage.

The first time I tried it, it prompted me to grant that, and I did. I wondered whether the header had been lost as a result of that somehow, but I tried it a second time with the permission already granted, and it failed the same way.

I've had a chance to examine the broken files more closely. It looks like they're missing the initial global header, and instead begin with the first packet header. (Enough network activity happens in the background that I don't know whether any actual packets from the beginning are being lost or not.) I don't see any sign of the global header (D4C3B2A1 etc.) anywhere else in the file - it seems to just be missing.

from rethink-app.

I just did some more testing, and it seems like once I start capturing (to either a file or logcat), it keeps going even after I turn it back off. Turning Rethink off and back on seems to stop the capture.

Yikes.

Network engine (vpnAdapter) must be instructed to stop capturing before the return on line 1718.

from rethink-app.

Fix: 3788577

from rethink-app.

Just got 055g through F-Droid, and this seems to be fixed. I've tested both Logcat and Downloads folder modes, and they both seem to stop immediately when I change the setting again. Thanks!

from rethink-app.

🤦 Sorry, I think perhaps I wasn't quite fully awake yet when I posted that, because I completely forgot to check on the thing this issue was originally about. But I can confirm that the new .pcap files seem to have the proper header, and are loaded correctly by Wireshark.

from rethink-app.

This is helpful. I think the ongoing "improvements" we are making where we never restart the network engine (regardless of whether the VPN service is restarted) might have caused this.

from rethink-app.

Could be. I also noticed that one of the test files kept getting written to for a long time after I thought I had stopped it, ending up over 2 GiB. I had convinced myself that I just missed stopping the capture somehow, but I just did some more testing, and it seems like once I start capturing (to either a file or logcat), it keeps going even after I turn it back off. Turning Rethink off and back on seems to stop the capture.

from rethink-app.

Thanks for confirming. The pcap file isn't malformed anymore, is it?

from rethink-app.