Multer worked on 5.0.1 throws internal server error in 5.1.0 about express-openapi-validator HOT 5 CLOSED

UPDATE: _d was not defined in the function, i defined it and now it works :)

Thanks for fixing my derp. I'll request a review on the PR.

from express-openapi-validator.

@tflolo - Do any of your security handlers depend on form values submitted as part of the multipart/form-data request? From the OpenAPI schema you posted, it doesn't look this this would be the case, unless you removed those values before pasting here?

from express-openapi-validator.

@mdmower - None of my security handlers does anything other than check for a valid session. The code i posted is complete, and only thing i change between runs is the version of express-openapi-validator from 5.0.1 to 5.1.0. I can try to move multipartMiddlware after securityMiddleware in 5.0.1 and see if that works.

from express-openapi-validator.

@tflolo - Is there a chance that you recently updated your openapi schema to support multiple uploads via oneOf schema? I was able to reproduce the same error as you, but the error I found also exists in version 5.0.5. To see if we're observing the same error, when version 5.1.0 is installed, could you temporarily update the following file and retest?

in node_modules/express-openapi-validator/dist/middlewares/openapi.request.validator.js, replace old line 131:

const type = (_c = (_b = (_a = schemaBody === null || schemaBody === void 0 ? void 0 : schemaBody.properties) === null || _a === void 0 ? void 0 : _a.body) === null || _b === void 0 ? void 0 : _b.properties[key]) === null || _c === void 0 ? void 0 : _c.type;

with new line:

const type = (_d = (_c = (_b = (_a = schemaBody === null || schemaBody === void 0 ? void 0 : schemaBody.properties) === null || _a === void 0 ? void 0 : _a.body) === null || _b === void 0 ? void 0 : _b.properties) === null || _c === void 0 ? void 0 : _c[key]) === null || _d === void 0 ? void 0 : _d.type;

I've drafted PR #878 (which outputs the compiled JS above) but would like confirmation that it resolves the issue.

UPDATE: I just noticed that your report says you updated from 5.0.1 to 5.1.0, so this is starting to make sense. Support for nested JSON in multipart bodies was added in 5.0.2. See e5cb5d6 .

from express-openapi-validator.

@mdmower The error changed,

      status: 500,
      text: '{"message":"_d is not defined"}',
      method: 'POST',
      path: '/api/wave-log/upload'

I upgraded to 5.1.0 and copied the line 131 you posted

UPDATE: _d was not defined in the function, i defined it and now it works :)

from express-openapi-validator.