Mode state management issue in the main screen about rutorrent-flutter HOT 2 CLOSED

Nice @rj-since-2000👏🏻. So you can replace all "consumer" usages with "Provider" wherever necessary and properly test all the functionalities once from your side too before pushing the changes.

from rutorrent-flutter.

@harchani-ritik Probably yes because the switch is actually present in the main screen, so we only need to refresh the main screen and the torrents list on toggle switch. Rest of the widgets can use Provider when they come in focus.

Actually after more research, I realised why do we even need a Consumer in the main screen. Let's try to analyse -

There are three providers - Api, GeneralFeatures and Mode

*(Api does not even extend ChangeNotifierProvider)
Api is used in -

'api.username'
Navigator.pushReplacement(context, MaterialPageRoute(builder: (context) => MainScreen())); is already calling the MainScreen to refresh on switching between accounts in the drawer. Thus it doesn't need a consumer to update in the UI.

'_getAccountsList(api, modeTheme, general)' in Drawer
Same as above

if (_currentIndex == 0) { showModalBottomSheet( isScrollControlled: true, context: context, builder: (BuildContext bc) { return AddBottomSheet( api: api, apiRequest: (url) { ApiRequests.addTorrent(api, url); }, dialogHint: 'Enter Torrent Url', ); }, ); } else { showModalBottomSheet( isScrollControlled: true, context: context, builder: (BuildContext bc) { return AddBottomSheet( apiRequest: (url) async { await ApiRequests.addRSS(api, url); setState(() {}); }, dialogHint: 'Enter Rss Url', ); }, ); }
Same as above

Now the GeneralFeatures -

It is used inside Drawer

'_getAccountsList(api, modeTheme, general)'
This just needs to pass provider of GeneralFeatures, so instead we can just pass provider. No need of Consumer.

'general.filterTileList' and 'general.listOfLabels'
These functions return data which isn't part of a Stream or any automatic change. Provider will work here.

'general.pageController'
This returns a controller defined in GeneralFeatures so it does not need a Consumer.

'general.pageController.jumpToPage(index)'
Same as above

Only the HomePage needs to be inside Consumer of GeneralFeatures because it has TorrentLists which is already inside a Consumer.
The DownloadsPage only needs homeDirectory to get the list of files. No need of Consumer.
RSSFeeds is already inside a Consumer it needs.
RSSFilterDetails just uses - rssFilters = await ApiRequests.getRSSFilters(Provider.of<Api>(context, listen: false)); so it also doesn't needs a Consumer in the tree root.

I tried debugging using a simple print('widget tree updated') inside the root widget of the main screen and with two providers(Mode and GeneralFeatures) and one Api class inside as it is now in the codebase, the print was being executed multiple times per second which is highly inefficient.

FUN FACT - I tried removing all the three Consumer in the root of the MainScreen and the app was working all fine with all updates in the torrent list, account change, account deletion, list sort, mode change, etc.

from rutorrent-flutter.