Git Product home page Git Product logo

Comments (2)

ccampbell avatar ccampbell commented on September 23, 2024

I see how this could be an issue, but it is a bit of an edge case and is something that is going to stay the way it is. The generic patterns are there for a reason so that common things can be shared with different languages.

Rainbow is not trying to figure out the variable in the context. Technically any variable that you use define() with becomes a constant, but assuming constants use all capital letters is simpler in my opinion.

I would say it would be a good idea to use define('STRUCT', 'test') in your code if you are going to be using it that way and then if you did echo STRUCT; it would be highlighted correctly. This also makes your code more readable.

from rainbow.

GeertDD avatar GeertDD commented on September 23, 2024

Yah, I see. By convention, normally I uppercase all my constants anyway. Better keep Rainbow lightweight instead of trying to make it jump through hoops for rare edge cases. Thanks.

from rainbow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.