Git Product home page Git Product logo

Comments (12)

cbrnr avatar cbrnr commented on June 15, 2024 2

Tests are not included in the sdist. It seems like we should just create a MANIFEST.in containing *.

from sleepecg.

cbrnr avatar cbrnr commented on June 15, 2024 1

Thanks @hoechenberger, if you have time to do it please go ahead! We can include the conda install command in our README once it's available.

from sleepecg.

hoechenberger avatar hoechenberger commented on June 15, 2024 1

WIP:
conda-forge/staged-recipes#15932

from sleepecg.

cbrnr avatar cbrnr commented on June 15, 2024 1

Thanks @hoechenberger! Let us know when it is available and we can include a link in our README.md. Also, we will release 0.3 soon so you don't have to vendor LICENSE anymore (I guess this will require an update to the formula?).

from sleepecg.

hoechenberger avatar hoechenberger commented on June 15, 2024 1

Also, we will release 0.3 soon so you don't have to vendor LICENSE anymore (I guess this will require an update to the formula?).

That will be just a really tiny change, I'll take care of this once 0.3 has been released :)

from sleepecg.

cbrnr avatar cbrnr commented on June 15, 2024 1

Nice! You can test them with our tests. Do you have numba as a dependency or is it just optional? In any case, we fall back to pure Python if neither C nor Numba are available (so the order of preference is C -> Numba -> Python).

from sleepecg.

hofaflo avatar hofaflo commented on June 15, 2024 1

Just ran the tests, seems to work, thanks @hoechenberger! :)

from sleepecg.

hoechenberger avatar hoechenberger commented on June 15, 2024

Just FYI, the recipe has been merged, but there's currently a CI problem that prevents the packages from being built & deployed. Hopefully this will be resolved soon.

from sleepecg.

hoechenberger avatar hoechenberger commented on June 15, 2024

The package is now available from conda-forge:

https://anaconda.org/conda-forge/sleepecg

Before doing an official announcement, we should probably ensure it actually works as intended 😅 I haven't tested the various "backends"; my understanding is that there's Python, numba, and C, right? They all SHOULD work but would be good to check

from sleepecg.

hoechenberger avatar hoechenberger commented on June 15, 2024

I included all optional dependencies 😅 and linked the C module against NumPy
Are the tests included in the sdist?

I'm out for coffee, will have a look at this later today 💪

from sleepecg.

hoechenberger avatar hoechenberger commented on June 15, 2024

@cbrnr sounds fair!

@hofaflo awesome, thanks! I think it's safe to announce the conda-forge package then!

from sleepecg.

cbrnr avatar cbrnr commented on June 15, 2024

Thanks @hoechenberger! If you have any idea how we can increase visibility, let us know at #25!

from sleepecg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.