PerFrameHandler Framework Issue: Stuck Handler Prevents Execution of Subsequent Handlers about cba_a3 HOT 8 OPEN

addMissionEventHandler ["ScriptError", {
    params ["_errorText", "_sourceFile", "_lineNumber", "_errorPos", "_content", "_stackTraceOutput"];
    private _src = _stackTraceOutput # 0;
    if ((_src#0 == "x\cba\addons\common\XEH_postInit.sqf") && {(_src#1 == 5)}) then {
        private _pfID = (_stackTraceOutput#2#3) get "_handle";
        systemChat format ["PFEH %1 has failed and will be removed", _pfID];
        diag_log text format ["PFEH %1 has failed and will be removed", _pfID];
        [_pfID] call CBA_fnc_removePerFrameHandler;
    };
}];

you can add that code and it should catch any failing PFEHs and remove them

but this doesn't belong in CBA because it could break things by removing a PFEH that only fails once
we could use a isNil wrapper but that has a perf penalty
ultimately the best solution is to not have code that can error

from cba_a3.

Code that breaks stuff should not be endorsed, even by being optional. Everything works as expected as is.

from cba_a3.

Solution can be based on my code here: https://pastebin.com/f7LDJxGv

from cba_a3.

Introduce a perFrameHandler that has a long execution time or gets stuck (e.g., infinite loop).

For example?

from cba_a3.

[{systemChat format ["A: %1", time];}, 0, []] call CBA_fnc_addPerFrameHandler; 
[{5 == []}, 0, []] call CBA_fnc_addPerFrameHandler; 
[{systemChat format ["C: %1", time];}, 0, []] call CBA_fnc_addPerFrameHandler;

C never runs

from cba_a3.

but this doesn't belong in CBA

maybe add this as optional

from cba_a3.

Could we consider making this code more resilient by optionally adding an isNil check (switch in Addons options?)? This would help in scenarios where it's crucial to avoid crashes and ensure continuity of operation, much like landing a satellite on the moon. A failure in one PFH shouldn’t compromise the entire landing operation (high-stakes, high-reliability scenarios).

from cba_a3.