Use after_config callback to redirect earlier in the bootstrap about moodle-tool_redirects HOT 7 CLOSED

@brendanheywood what was the intention on this issue? I just saw it in the code and realised that the redirect won't work as $PAGE doesn't have any URL when after_config gets called.

from moodle-tool_redirects.

It actually caused #4 and we fixed it as https://github.com/catalyst/moodle-tool_redirects/blob/master/classes/helper.php#L104

But this hook would never work anyway.

from moodle-tool_redirects.

Yeah you are right, but this hook could still work just by using the real url and not the $PAGE object

from moodle-tool_redirects.

I'm trying to figure out what was the reason for this hook? Any issues using before_http_headers?

from moodle-tool_redirects.

I think before_http_headers is only called from a rendered page so there is a lot of edge cases it doesn't touch and after_config would get all of them. It was probably to avoid some situations with a double or triple redirect and make it faster

from moodle-tool_redirects.

Can you think of any not rendered page/URL that we would like to redirect from?

from moodle-tool_redirects.

The one which jumps to mind is code which does some logic and then redirects somewhere else, eg sso, and we'd want this to trigger first. I really dunno and can't remember why I wanted this. I'm fine to revert it until we find and document a proper use case

from moodle-tool_redirects.