Comments (5)
bump, this is insanely useful for rockbox users
from onthespot.
I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png
all the time like I did in my fork?
https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file
from onthespot.
I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as
cover.png
all the time like I did in my fork?https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file
This being a default behavior won't be too bad as i have seen a lot of media player use it instead of embedded one or using embedded ones only if cover.png is missing !
Good to know you got it working, normally i wold have suggested you to make a PR, but since i am rewriting onthespot all PR and non critical Issue resolution are paused right now. I may make this a default behavior but configurable using the config files in the rewrite.
from onthespot.
I also have a version that works on my fork, even with a settings option you can tick. I used .jpg
tho, because that's what Spotify gives you.
If the file already exists, it skips it.
https://github.com/artofsound/onthespot/tree/cover_image
from onthespot.
I used .jpg tho, because that's what Spotify gives you.
Ah I just used png because that's what the method set_music_thumbnail
used a few lines above my text. Not unnecessarily converting between formats is probably more efficient...
If the file already exists, it skips it.
Same!
I may make this a default behavior but configurable using the config files in the rewrite.
Sounds perfect! Thanks!
from onthespot.
Related Issues (20)
- [BUG] build from source - qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found HOT 3
- [BUG] Get metadata failed HOT 18
- [BUG] Nothing in progress bar along with an error HOT 1
- Playlist "error"
- [BUG] HOT 1
- issues with save path when using ' on windows. Final conversion from ogg to mp3 fails due to output string error to ffmpeg.
- Playlist download does not reflect recent changes in the playlist HOT 1
- Download failed !!! HOT 2
- [BUG] Files all fail at 99% HOT 3
- Track number 01, 02, ... 10, 11, ... HOT 1
- ERROR -> Download process returned false: 7H4LlyRX0YjXhJFLN5nIae HOT 3
- [BUG] Playlist not getting refreshed HOT 4
- Volume/file name/directory incorrect? [BUG]
- Error: Connection forcibly closed, playlist has some items left to download
- [BUG] Files missing HOT 3
- Dark mode HOT 3
- [Not about onthespoyt] Your ssl certificate for your website is expired
- Decode Error Bug
- [BUG] Failed to get lyrics for track id: HOT 3
- [Question] Download settings recommendation HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onthespot.