Comments (7)
Yes, I'm one of those :) So the most recent pyserini commit broke my evn...
Thoughts @x65han ?
from pyserini.
I'm fine with it as I never used a enviroment or package that requires python 3.6 or lower.
from pyserini.
I believe it might be a bit early for this? I mean I personally use python 3.7 but I feel like there is a significant number of users still stuck on python 3.6 or lower. Most other widely-used nlp packages don't yet require python 3.7 or higher, so maybe wait until a few start switching before we follow suit.
from pyserini.
I am okay with either, but you are right.
You are right, this only works on python 3.7. I don’t really need this. I only need this for type annotation.
In a class, if I have a function that returns itself. For example:
Class TrecRun:
def clone(self) -> TrecRun:
pass
Python won’t pick up type annotation unless I use __future __
I am ok with removing it.
from pyserini.
Here's the PR to remove it for now. It's pretty easy to add back if we decide to move to P37 later.
from pyserini.
Just want to note the tradeoff here:
Without __future__, we don't have an elegant way to return the class type within that class. Referring to this post on Stack Overflow.
Python <3.7, the closest we can do is:
class Position:
...
def __add__(self, other: 'Position') -> 'Position':
...
from pyserini.
Closing for now!
from pyserini.
Related Issues (20)
- merge a large index with small index \ adding small collection of docs to a large index
- Pyserini download index doesn't actually appear to check tarball size
- Install Failed building wheel for nmslib with pybind11-2.6.1
- How are you handling duplicate entries for the corpus and qrels? HOT 1
- mContriever pre-built index for Mr.TyDi datasets
- Support for jsonl.gz input in pyserini.encode
- Optimizations when building a dense index
- Improper Contriever encoding with the current pyserini.encode class
- Error When Setting Up Pyserini: python -m spacy download en_core_web_sm
- Issue with fetching raw documents
- Create a `Rerank` module in Pyserini
- Contriever training script & hyper-parameter values
- Trying to index own corpus
- Lucene query runtime
- Exception: Unable to find javac HOT 1
- NEED HELP: How to get original documents from Faiss index?
- Enhance Onboarding Documentation: Highlight Existing Embedded Indexes
- Update docs about fetching doc text given docid for dense indexes HOT 1
- Missing module 'jnius_config'
- List of encoder supported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyserini.