setup.py's use of `open` should explicitly specify encoding about nap HOT 4 CLOSED

Hi folks, just wanted to chime in and suggest taking a look at io.open as well. It's a Python 2 backport of the Python 3 built-in open functionality, so it might be more familiar to the average user than the codecs library.

👋

from nap.

I agree with your assessment on using codecs.open. The only caveat I can see is that the encoding format chosen must marshal successfully to and from Python 3 bytes - UTF-8 will fit the bill there.

Python 2: https://docs.python.org/2/library/codecs.html#codecs.open
Python 3: https://docs.python.org/3/library/codecs.html#codecs.open

encoding specifies the encoding which is to be used for the file. Any encoding that encodes to and decodes from bytes is allowed, and the data types supported by the file methods depend on the codec used.

from nap.

Check this out for testing purposes: https://pymotw.com/3/codecs/#working-with-files

from nap.

Used the io library to specify encoding.

from nap.