No rollback of memory data when adapter throw exception about casbin.net HOT 8 CLOSED

Casbin.NET follows Golang's Casbin's work flow. So please send a GitHub issue to: https://github.com/casbin/casbin/blob/master/internal_api.go#L22 first

from casbin.net.

I have go through GoLang's work flow.I have following doubts.

if !ruleAdded {
		return ruleAdded, nil
	}

it says if not equal to ruleAdded return become true or not ?? What does return ruleAdded mean here?Does it give true or false ?

from casbin.net.

This control structure means, that if ruleAdded is false, it means if the rule is not added to the memory, the function returns false, nil(error).

from casbin.net.

This control structure means, that if ruleAdded is false, it means if the rule is not added to the memory, the function returns false, nil(error).
@divypatel9881
Now clear.Thanks for the response.

from casbin.net.

In InternalEnforcer.cs, there are 3 methods add or remove policy data. All these methods will add or delete data in memory first then call adapter to perform the mutation of data in data store behind the adapter.

It will cause data inconsistency issue if no revert or rollback logic in all those methods. Please refers to the bold area of the partial code below:

bool ruleAdded = model.AddPolicy(sec, ptype, rule);
if (!ruleAdded)
{
    return false;
}

if (adapter != null && autoSave)
{
    try
    {
        await adapter.AddPolicyAsync(sec, ptype, rule);
    }
    catch (NotImplementedException)
    {
    }
    catch (Exception e)
    {
       **// rollback logic to revert the related memory data**
        throw e;
    }

    if (watcher != null)
    {
        // error intentionally ignored
        watcher.Update();
    }
}

Why not catching for NotImplementedException ? Don't we need to show at lease error message ?

from casbin.net.

I think we agreed on updating adapter first, then update memory in Golang: casbin/casbin#415 (comment). Let's follow the similar pattern in .NET. Can anyone make a PR for it?

from casbin.net.

@huazhikui @xcaptain @sagilio @twchiam can you work on this one?

from casbin.net.

@twchiam merged in: #28

from casbin.net.