release asset size error (due to 404 during asset download) about vendir HOT 7 CLOSED

Thanks so much for the quick fix! This is working for me now.

from vendir.

hmm, interesting. here is the code: https://github.com/k14s/vendir/blob/7e9c900d438eac21867e24be007411e7ba1fc156/pkg/vendir/directory/github_release_sync.go#L74-L82

it downloads and then checks size. i wonder if there is some http error being returned because downloadFile isnt checking for 200 status. you might be hitting github rate limit error: https://github.com/k14s/vendir/blob/develop/docs/github-release.md#github-api-rate-limiting ?

from vendir.

Thanks for looking into this @cppforlife. I am using a personal access token since this repo is private, so I think it would be pretty unlikely that I hit a rate limit. I also haven't seen any issues at all when requesting the file directly via browser or wget request with the token.

from vendir.

I added a conditional in there to throw an error if the response is non-200 and it looks like I'm getting a 404 for the asset download. Have you confirmed that this works for private repos? I wish I could share more info with you to help troubleshoot...

from vendir.

I used this handy script for sanity checking https://gist.github.com/josh-padnick/fdae42c07e648c798fc27dec2367da21

from vendir.

hmm, looks like github asset download url didnt work for private repos. switching to asset resource url + header does seem to work. fixed in 47d346d. will cut release right after CI passes.

from vendir.

shipped in https://github.com/k14s/vendir/releases/tag/v0.9.0

from vendir.