Comments (5)
This change happened when we started preserving image tags throughout copying.
Looking over the code, it seems we now parse the ref generically. We parse using NewDigest if it is a digest reference, otherwise we parse it as a tag.
https://github.com/vmware-tanzu/carvel-imgpkg/blob/d4982fa6c0aa2ef64e4151e39b91785e437610bf/vendor/github.com/google/go-containerregistry/pkg/name/ref.go#L39-L46
We should look into why we no longer use regname.StrictValidation
when using NewDigest.
we should still be parsing refs as digests
It looks like we are still doing this. Am I missing something here?
if we are trying to transfer over tags then i would imagine it should be an additional field and not muddy up ref itself
Can you explain what you mean by "transfer over tags here" and your vision for "not muddy up ref itself"?
from imgpkg.
the intent of ImageSet is to work with concrete images (== digest refs); however, for some images we also want to throw in additional metadata like a tag. that meaning was changed by having ImageSet do tag resolution. this now means that i could call ImageSet.Export twice and get different results because tag may change.
from imgpkg.
I agree, we want to have ImageSet use digest references, rather than accept a digest or a tag. Doing this will ensure that the image references are in digest form and a ref always maps to the same image.
Like you said, we can refactor ImageSet to parse image urls with NewDigest
rather than ParseReference
as it is now to address this.
Still not sure I 100% understand the idea that tags should be an additional field but it would be something to think about when someone picks this up and looks closer at the code.
from imgpkg.
fixed as part of #48
from imgpkg.
Closing issue with release of version 0.3.0
from imgpkg.
Related Issues (20)
- Having the log implementation all internal causes friction when consuming imgpkg as a library
- Case when the registry link for pull is a image but the flags are -I along with —image-is-bundle-check flag=true which results in the image being pulled. HOT 5
- Are you using imgpkg?
- add ability to specify the select directories/files to be pulled/outputted. HOT 6
- Relocating bundle to Google Artifact Registry using `--repo-based-tags` fails HOT 1
- Sign `imgpkg` binaries while releasing them HOT 1
- imgpkg should emit plain text to be used in pipelines by default
- Add a limiter for pushing images HOT 3
- imgpkg miscalculates apache/nifi copy, produces corrupt image layer when copying apache/nifi in a bundle HOT 1
- Consider using OCI compliant media-types HOT 2
- imgpkg with flag --json swallows error
- Command `describe` does not include `metadata`. HOT 1
- imgpkg v0.40.0 breaks with relocated image HOT 2
- Imgpkg describe fails to print the output for the larger images HOT 1
- Update copyright headers
- Imgpkg describe fails to describe a bundle pushed to the repo
- Upgrade cosign version to latest version in GitHub workflows
- Cannot build for `GOARCH=386`
- Is there any way to disable progress bar shown during pushing of images ? HOT 5
- Bring tests against harbor back
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imgpkg.