Product thumbnail not showing properly about angular2-shop HOT 9 OPEN

Image that is not showing is cart image
for that you have to change angular-cli.json file little bit

just change
"assets": "assets",

To This

"assets": [
        "assets",
        "favicon.ico"
      ],

and do npm install or ng update if your using angular cli as global

from angular2-shop.

The project has been upgraded to Angular 5. I couldn't replicate this issue in this new version. Can you please try again and double check if the issue still remains? I'm happy to reopen the ticket should you still have trouble with this.

from angular2-shop.

I'm experiencing the same issue with the scrollbars in the product thumbnails like in the image above. However, the shopping cart icon is showing. I'm new to Angular as of 2 weeks ago so, everything is fresh to me. I'm running: Angular: 5.2.1.

from angular2-shop.

Hey @tiedyejedi thanks for the report. Mind sharing a screenshot of how it looks like on your end? I'm on Mac so I can't easily replicate the behaviour. Thanks!

from angular2-shop.

localhost:

your demo looks fine...

worse when page is shrunk...

demo is still fine....

I did notice this warning in Visual Studio Code:

Your global Angular CLI version (1.7.3) is greater than your local
version (1.6.5). The local Angular CLI version is used.

Never seen that before and I probably just didn't see it yesterday when I
installed your shopping cart. Also, I downloaded the github file rather
than use the CLI.

from angular2-shop.

Update:

removing this style fixes it:

position: relative;

in the .info and .wrapper classes of the product-thumbnail.component.sass file.

So, my wrapper is now:
.wrapper{
border-radius: 5px;
box-shadow: 0 5px 5px;
text-align: center;
display: block;
background-color: white;
box-shadow: 0 6px 17px rgba(0,0,0,0.07);
}

and deleted the .info one as the position was the only thing in it.

The best seller tag is removed, but I don't want that anyways. In fact, I'll be removing a lot more features. I don't need a search or order by. Not sure if it's possible, but making it more modular would help, IMO. That is, if it's even possible.

I do like this shopping cart. Very well done! I do hope I can get it to work in my app, but at least I got a demo working on my server, so we'll see.

from angular2-shop.

Hey @tiedyejedi thanks for the follow up! Glad you figured it out. Yeah, the project isn't well organized actually, sorry about that. It was really not meant to be, I built it super quick and shoot the code here :D thanks again for the feedback, I'll use this to fix the scrollable thing.

from angular2-shop.

No problem about the organization. I like figuring things out. However, I just noticed my "fix" breaks the view details aspect of it, which is critical, but maybe something I can work around.

from angular2-shop.

I wonder, what if you try setting overflow: hidden to the .info class? if that won't work, try also in the .wrapper class although that may hide the best-seller tag (but you don't need it anyways). Keep the position: relative if that's breaking the detail view. Disabling the overflow might do the trick to hide those scrollbars.

from angular2-shop.