Git Product home page Git Product logo

Comments (2)

augustearth avatar augustearth commented on June 8, 2024

So, on closer inspection, the vine infrastructure could benefit from a more extensive refactor. The following seems true:

  • The two valuable aspects of the Vine machinery are caching and H2.
  • Caching does not make obvious sense for H2 file vines.
  • FileVines on their own are pretty useless.
  • The VineMethod interface is really only necessary to enable caching and is otherwise a pain.
  • There does not seem to be a good argument to have a top level Vine class or interface that would cover all vines, though there are families of related vines.

Do the following:

  • Get rid of Vine.
  • Make CachingVine a top level class to replace Vine.
  • Make H2FileVine a top level class.
  • Remove caching from H2FileVine.
  • Rename VineMethod to CachingVineMethod to make it clear where it applies.

from carnival.

augustearth avatar augustearth commented on June 8, 2024

Closing this issue. Further discussion is required. Will copy the material here to the Team discussion.

from carnival.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.