Comments (2)
So, on closer inspection, the vine infrastructure could benefit from a more extensive refactor. The following seems true:
- The two valuable aspects of the Vine machinery are caching and H2.
- Caching does not make obvious sense for H2 file vines.
- FileVines on their own are pretty useless.
- The VineMethod interface is really only necessary to enable caching and is otherwise a pain.
- There does not seem to be a good argument to have a top level Vine class or interface that would cover all vines, though there are families of related vines.
Do the following:
- Get rid of Vine.
- Make CachingVine a top level class to replace Vine.
- Make H2FileVine a top level class.
- Remove caching from H2FileVine.
- Rename VineMethod to CachingVineMethod to make it clear where it applies.
from carnival.
Closing this issue. Further discussion is required. Will copy the material here to the Team discussion.
from carnival.
Related Issues (20)
- Add CONTRIBUTING.md HOT 2
- Make installation instructions more prominent in the documentation for users HOT 4
- I am not sure whether I want a library or application. Maybe add a line somewhere explaining the differences and different use cases? HOT 2
- Is Carnival limited to Groovy + Gradle? Or would it work with other JVM languages and other build tools like Maven or Ant/Ivy? HOT 2
- Easier docker example HOT 1
- JOSS paper - reasoning HOT 2
- JOSS Paper text first notes HOT 2
- please add missing API documentation items HOT 10
- Remove dependency on groovy.util.AntBuilder
- Evaluate related projects
- Release v3.0.1 HOT 2
- Deploy 3.0.1 to Gradle plugin library HOT 1
- JOSS paper missing spaces HOT 1
- Remove `CarnivalApplicationPlugin.groovy`
- difference in demo application links between paper and README.md HOT 1
- JOSS paper–functional claims
- MethodsHolder needs to look up the inheritance tree to find methods
- Remove support for Neo4j
- Add support for JanusGraph BerkelyDB
- Add an execution context to GraphMethod execute() method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carnival.