Comments (5)
Not sure whether how best to go about building the new infrastructure in parallel with the old. Will start by removing extraneous references to carnival.core.vine package.
from carnival.
After doing the above, it looks like references to carnival.core.vine are now limited to the carnival.core.vine package. So, we can probably just rename current carnival.core.vine to carnival.core.vineold and start fresh with an empty carnival.core.vine package. This is a breaking change of course, but we've already introduced breaking changes. So, why not.
from carnival.
Next step is to prep the current code for the new TabularVine branch.
- rename JsonVine to Vine
- add VineMethodInterface
- JsonVineMethod implements VineMethodInterface
from carnival.
- Old vine code has been moved to carnival.core.vineold
- JsonVine has been renamed to Vine
- A initial implementation of MappedDataTableVine* is complete
There is definitely more to do. For one, there is a disparity between the cache methods of JsonVine and MappedDataTableVine. JV has a single cache file. MDTV has two. Created an object DataTableFiles to encapsulate the two files of a data table, but we should probably do something more standardized across vines. Will add an issue for this.
GenericDataTableVine* has to be added as well. Will create a separate issue. Hopefully, we can leverage inheritance and/or composition to share code between Mapped and Generic data table vines.
Also, it occurs to me that there are no facilities in the new vine classes to open/close database connections. Maybe that's ok. Will have to have a design discussion with @hjwilli. Things are probably at a good enough stopping point to merge with master.
from carnival.
Furthermore, I do think it's time to make Vine v2 a milestone. Will close this issue with next commit, create a milestone, and add finer grained tickets to it.
from carnival.
Related Issues (20)
- Add CONTRIBUTING.md HOT 2
- Make installation instructions more prominent in the documentation for users HOT 4
- I am not sure whether I want a library or application. Maybe add a line somewhere explaining the differences and different use cases? HOT 2
- Is Carnival limited to Groovy + Gradle? Or would it work with other JVM languages and other build tools like Maven or Ant/Ivy? HOT 2
- Easier docker example HOT 1
- JOSS paper - reasoning HOT 2
- JOSS Paper text first notes HOT 2
- please add missing API documentation items HOT 10
- Remove dependency on groovy.util.AntBuilder
- Evaluate related projects
- Release v3.0.1 HOT 2
- Deploy 3.0.1 to Gradle plugin library HOT 1
- JOSS paper missing spaces HOT 1
- Remove `CarnivalApplicationPlugin.groovy`
- difference in demo application links between paper and README.md HOT 1
- JOSS paper–functional claims
- MethodsHolder needs to look up the inheritance tree to find methods
- Remove support for Neo4j
- Add support for JanusGraph BerkelyDB
- Add an execution context to GraphMethod execute() method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carnival.