Git Product home page Git Product logo

Comments (13)

Vetro7 avatar Vetro7 commented on July 29, 2024 1

Well then I guess we should probably inform the others that I have mentioned in this as well.

from incentivized-testnet-stakepool-registry.

Heinrich-CH avatar Heinrich-CH commented on July 29, 2024 1

from incentivized-testnet-stakepool-registry.

Vetro7 avatar Vetro7 commented on July 29, 2024

Going a bit deeper into this, I'm sure you guys already have a plan for once this initial phase is complete and we have to maintain our records current. As I'm sure you already have ready a way for us to sign with an old key, before changing to a new key, to prove we are the original owner more then just our Github usernames. Maybe you could use one of those future solution for this, and have us sign for updates to a "duplicate ticker", maybe with an ed25519_pk1888888888.ver file to verify ownership and changes. Anyway just a thought, I don't like bring up bugs without at least an attempt at a solution.

from incentivized-testnet-stakepool-registry.

KtorZ avatar KtorZ commented on July 29, 2024

Hi @Vetro7 , this is not a bug but an actual feature. We've limited the modifications to two files to make manual review easier and also, doesn't add too many level of complexity to the CI validation tool which is already complicated enough.

To be clear, you're trying to change the public key associated with a ticker which is something that is so-to-speak forbidden. If you could do it, then anyone else also could 😉 ! There's no issue with trying to update the rest of your metadata, but changing the public key and therefore, the ownership is not something you can do without the ticker being first given up by the owner (i.e., you).

To solve this, you'll need 2 pull requests:

  1. A first PR that "voids" the ticker associated with your current public key (e.g. "VOID0")
  2. A second PR, that re-register this ticker on a new public key (that can only be merged after the first one has been merged!).

As a result of 1., we could also remove the voided files altogether. We can't simply remove files on request by the way, because what proves that you are who you say you are 🙃. This is what the signatures are for.

from incentivized-testnet-stakepool-registry.

Vetro7 avatar Vetro7 commented on July 29, 2024

There will be plenty more as well, I will keep an eye out for, as the mnemonic function later release has caused this for most.

from incentivized-testnet-stakepool-registry.

Vetro7 avatar Vetro7 commented on July 29, 2024

looks like you have a real bug in buildkite now.. as the VOID0 has passed but throws this error

#337

Success

--( Checks passed.

Running global pre-exit hook
$ /nix/store/7k8gr1s69hj9w243b0i59pd26g23kk72-buildkite-agent-hooks/pre-exit
rm: cannot remove '/tmp/systemd-private-9dbadb5665fb482d9be5843d34457d2e-nscd.service-zNqkqb': Operation not permitted
rm: cannot remove '/tmp/systemd-private-9dbadb5665fb482d9be5843d34457d2e-systemd-logind.service-DtbX1d': Operation not permitted

from incentivized-testnet-stakepool-registry.

KtorZ avatar KtorZ commented on July 29, 2024

Yes, we are aware and actively working on it :)

See: #403 (comment)

from incentivized-testnet-stakepool-registry.

Heinrich-CH avatar Heinrich-CH commented on July 29, 2024

Hi, interesting discussion!
So, according to KtorZ, it isn't it just possible to "revert" the initial commit (graphically from github) and re-submit new files (tried in #427). I'll have to try to do the VOID way then.

from incentivized-testnet-stakepool-registry.

Heinrich-CH avatar Heinrich-CH commented on July 29, 2024

Ok, I VOIDed my initial commit (#433). But if I re-submit, the build will fail (old pool ticker still part of master). Can I leave #360 open for consideration? Or can it never be considered since the build failed once?

from incentivized-testnet-stakepool-registry.

KtorZ avatar KtorZ commented on July 29, 2024

@Heinrich-CH #433 has been merged and I've just updated your branch on #360 to be on latest master. It's green and ready to be merged ;)

from incentivized-testnet-stakepool-registry.

cardanohawaiipool avatar cardanohawaiipool commented on July 29, 2024

Hi @KtorZ, I sent the email, but my original PR is #199.

from incentivized-testnet-stakepool-registry.

maneav avatar maneav commented on July 29, 2024

Hi @KtorZ please delete my currently merged ARM1 pool #94 , then please review this pull request #544 and merge. Thanks.

from incentivized-testnet-stakepool-registry.

stakeada avatar stakeada commented on July 29, 2024

Hi @KtorZ, please delete my current pool #617 (has been VOIDed) and review the #618 (whose checks should also pass afterwards) and merge. Thanks

from incentivized-testnet-stakepool-registry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.