Comments (6)
@piotr.stachyra indeed, and it doesn't have to be. This is the wallet layer to which the API layer talks to.
The representation of the second factor as a mnemonic sequence is really just a detail of the API.
Actually, we could say the same for the main mnemonic and have the wallet layer receives a seed directly.
from cardano-wallet.
add kernel and API layers
This isn't exactly true. So here, we are interested in our WalletLayer which sits between the API Layer, the Network Layer and the DB Layer. I'll provide a diagram on slack to make things a bit clearer. But this particular task is NOT about creating the API layer.
What we need here is really just a few effectful functions that can compose the functions from:
- The wallet business logic (
Cardano.Wallet
-- which is the equivalent of our old Kernel here) - The network layer
- The db layer (which doesn't exist so far so we'll have to sketch a small module api for that and emulate it with an
MVar
).
from cardano-wallet.
This now sounds like duplicated with #69. I'll close #69 in favor of this one, but move this one in the next milestone 👍
from cardano-wallet.
Okay, re-reading the decisions, they aren't really the same. This one is about implementing the create
and get
part of the wallet layer, while #69 is really about the wallet worker which would apply block and maintain a wallet state. So, they are related and will share a state through the DB layer, but they aren't strictly the same.
from cardano-wallet.
@paweljakubas, @KtorZ - looking at https://github.com/input-output-hk/cardano-wallet/blob/master/src/Cardano/WalletLayer.hs#L71-L75
data NewWallet = NewWallet
{ mnemonic
:: !(Mnemonic 15)
, mnemonic2ndFactor
:: !(Passphrase "generation")
this does not to seem to be inline with API spec ->
mnemonic_sentence - Array of string <bip-0039-mnemonic-word{english}> [ 15 .. 24 ] items
mnemonic_2nd_factor - Array of string <bip-0039-mnemonic-word{english}> [ 9 .. 12 ] items
from cardano-wallet.
lgtm 👍
from cardano-wallet.
Related Issues (20)
- Stake pool monitor exit: Unhandled exception: SQLite3 returned ErrorIO while attempting to perform step: disk I/O error HOT 5
- Upgrade cardano-wallet to build with ghc-9.6 HOT 1
- Compatibility with `cardano-node` version `8.0.0` HOT 10
- Adahandle support
- Publish tag 2023-07-18 on Docker hub HOT 2
- Invalid link in `CONTRIBUTING.md` file HOT 2
- Cardano wallet's threads are dying while syncing HOT 1
- MacOS ARM64 builds HOT 3
- Can't sign tx with "mustBeSignedBy" constraint with a stakeKey. HOT 3
- Expose Wallet Engine Sync Progress API HOT 4
- cardano-wallet is not getting synced up HOT 12
- cabal build all with v2023-07-18 tag not working HOT 1
- Documentation / interface for hardware wallets HOT 3
- CHaP release HOT 3
- "The machine terminated part way through evaluation due to overspending the budget" HOT 1
- Quickstart Bash Script Error: tar file cannot be decoded. HOT 1
- cardano-wallet NixOS module not working with cardano-node NixOS module HOT 1
- 🐞 Bug: JSON roundtrip property broken for `TxMetadataWithSchema`. HOT 2
- 🐞 Bug: HTTP API returns "Internal Server Error" when attempting to encrypt multiple transaction metadata messages. HOT 2
- Lost my wallet passphare HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cardano-wallet.