Git Product home page Git Product logo

Comments (4)

captbaritone avatar captbaritone commented on July 28, 2024 1

Module remapping must be done carefully to ensure a single graphql version is pulled, otherwise graphql itself will complain.

This is also a problem generally, but maybe easier to hit in deno? One thing we might want to do in Grats is move toward a model where graphql is a peer dependency. We are tightly coupled with that package so our support range would be narrow, but it might help avoid the very confusing failure mode where you have two instances.

I think a good next step here would be to add an example deno project here that encodes these issues. Even if it's not a perfectly smooth setup today, it would document the existing workarounds and let us at least capture the situation. As/if we are able to improve that situation, we would be able to update that example as well.

@mandx , If you're interested in working on that, feel free to submit a PR, but no pressure.

from grats.

mandx avatar mandx commented on July 28, 2024

(Still tinkering on this) Had to use module remapping to force Grats to use the same (newer) Typescript version used in Deno (v5.2.2 at this time) to be able to make it generate a schema from classes/types spread across several TS modules.

The example repo at this time has all resolver classes in a single module and it works fine; but as soon as I did a little refactoring and split the code into some modules, Grats started erroring on "this types are not tagged with @gqlType, etc".

from grats.

captbaritone avatar captbaritone commented on July 28, 2024

Would the TS version be fixed if we switched to making TypeScript a peer dependency (with constrained versions?)

from grats.

mandx avatar mandx commented on July 28, 2024

The problem specific to Deno is just the version used. I think after v5, TS got smarter about module resolution, which might explain why Grats works with this Deno codebase, but it doesn't with TS v4.9 (the version Grats pulls at the moment).

I'm not sure if the concept of "peer dependency" applies to Deno, but in general, yeah, I think Grats does need to declare typescript as a peer dependency; this would make sure that all code is checked against a specific version, also, TS is a heavy dependency; I definitely wouldn't want 2+ TS versions in my node_modules directory.

from grats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.