Git Product home page Git Product logo

Comments (10)

leehambley avatar leehambley commented on June 4, 2024 1

As you an see from the implementation the linked_dirs variable is not set - https://github.com/capistrano/file-permissions/blob/master/lib/capistrano/tasks/file-permissions.rake#L9 (not my library, but I saw the GH notification and decided to take a quick look)

I might suggest that the implementation be changed, from:

linked_dirs.include?(d) ? shared_path.join(d) : release_path.join(d)

to:

Array(linked_dirs).include?(d) ? shared_path.join(d) : release_path.join(d)

from file-permissions.

peterjmit avatar peterjmit commented on June 4, 2024

Thanks @leehambley, I will make that change ASAP

from file-permissions.

leehambley avatar leehambley commented on June 4, 2024

Cool @peterjmit :-)

from file-permissions.

 avatar commented on June 4, 2024

@peterjmit Cool, thanks!

from file-permissions.

 avatar commented on June 4, 2024

@peterjmit Could you please update this gem in the Capistrano repo (https://github.com/capistrano/file-permissions) as well, so the rubygems website fetches the correct files. (http://rubygems.org/gems/capistrano-file-permissions)

from file-permissions.

peterjmit avatar peterjmit commented on June 4, 2024

Im not sure what you mean about updating the capistrano repo - I will tag another release and push a new gem to ruby gems though

from file-permissions.

 avatar commented on June 4, 2024

My bad, the old version of the code still resides on https://github.com/peterjmit/capistrano-file-permissions, seems like this one is used by ruby gems.

from file-permissions.

peterjmit avatar peterjmit commented on June 4, 2024

Ah, Ill get that fixed now. I'll delete the old repo to avoid confusion

from file-permissions.

peterjmit avatar peterjmit commented on June 4, 2024

@GerritBertier new gem published https://rubygems.org/gems/capistrano-file-permissions

from file-permissions.

 avatar commented on June 4, 2024

Works like a charm, thanks!

from file-permissions.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.