Comments (23)
@Idrimi hmm getting a few errors when trying to build my app using the develop branch of the plugin. Few errors with "browser doesn't contain a valid alias configuration".
I might just have to wait till develop gets merged into master when you are happy with it.
from contacts.
HI @Idrimi,
I am also stuck with this. Any update on Contacts to support on Capacitor 3?
from contacts.
I have a private fork that's working well with Capacitor 3. Might find some time to open a PR or two if @Idrimi doesn't already have plans to finish adding support.
from contacts.
@thomasvidas thx. I will leave this open until dev branch is merged into master.
@Yuripetusko did you test ios only or android as well? iOS should be stable, but haven't had the chance to test android.
from contacts.
I'm closing the issue.
https://github.com/capacitor-community/contacts/releases/tag/1.0.9
from contacts.
@thomasvidas thx. Was waiting for this. I will upgrade it as soon as i have a spare moment.
from contacts.
Hi Thomas,
Noticed v0.1.1 is not working on iOS with Capacitor v2.4.4 - Is that because of Capacitorv3 or a bug?
My package.json:
"dependencies": {
"@angular/animations": "^10.0.0",
"@angular/common": "~10.0.0",
"@angular/core": "~10.0.0",
"@angular/fire": "^5.4.2",
"@angular/forms": "~10.0.0",
"@angular/platform-browser": "~10.0.0",
"@angular/platform-browser-dynamic": "~10.0.0",
"@angular/router": "~10.0.0",
"@capacitor-community/contacts": "^0.1.1",
"@capacitor-community/fcm": "^1.1.0",
"@capacitor/core": "^2.4.4",
"@capacitor/ios": "^2.4.4",
"@ionic-native/core": "^5.0.0",
"@ionic-native/splash-screen": "^5.0.0",
"@ionic-native/status-bar": "^5.0.0",
"@ionic/angular": "^5.0.0",
"@ionic/pwa-elements": "^3.0.2",
"apexcharts": "^3.23.1",
"bootstrap": "^4.5.3",
"chart.js": "^2.9.4",
"firebase": "^7.10.0",
"moment": "^2.27.0",
"ng-apexcharts": "^1.5.6",
"ngx-image-cropper": "^3.3.3",
"ngx-spinner": "^10.0.1",
"rxjs": "~6.5.5",
"sweetalert2": "^10.13.0",
"tslib": "^2.0.0",
"zone.js": "~0.10.3"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.1000.0",
"@angular/cli": "~10.0.5",
"@angular/compiler": "~10.0.0",
"@angular/compiler-cli": "~10.0.0",
"@angular/language-service": "~10.0.0",
"@capacitor/cli": "^2.4.4",
"@ionic/angular-toolkit": "^2.3.0",
"@types/jasmine": "~3.5.0",
"@types/jasminewd2": "~2.0.3",
"@types/node": "^12.11.1",
"codelyzer": "^6.0.0",
"jasmine-core": "~3.5.0",
"jasmine-spec-reporter": "~5.0.0",
"karma": "~5.0.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage-istanbul-reporter": "~3.0.2",
"karma-jasmine": "~3.3.0",
"karma-jasmine-html-reporter": "^1.5.0",
"protractor": "~7.0.0",
"ts-node": "~8.3.0",
"tslint": "~6.1.0",
"typescript": "~3.9.5"
},
from contacts.
@Idrimi hello, do you have any timelines on when you think you'd be able to upgrade the plugin to support Capacitor v3.0?
from contacts.
Hi @KirstenStake,
just tried it this weekend. You can test the develop branch. Should work with cap 3.
from contacts.
@KirstenStake Android or iOS? iOS is tested. Android will follow.
from contacts.
@Idrimi error was being received when trying to build for ios. Steps I did were:
- installed the develop branch directly from the repo via npm
- npm installed @capacitor/core@next as was requiring it as a peer dependency
- built for ios
Error received:
Cannot find module '@capacitor-community/contacts' or its corresponding type declarations.
How I imported the plugin in my .ts file was as follows
import { Contacts } from '@capacitor-community/contacts';
as the previous way of
import { Plugins } from '@capacitor/core'; const { Contacts } = Plugins;
is no longer possible for cap v3 and also threw an error
from contacts.
Thx for testing. i'll have a look at it.
The way you do the import seems right.
Do not know how to migrate Apps to cap 3 properly yet. Had to kill ios plattform completely, then add it again.
This branch here is working: https://github.com/byrdsandbytes/capContactsDemo/tree/develop using a local version of the plugin
from contacts.
@Idrimi @KirstenStake the reason using the branch doesn't work is because the package doesn't get built (so dist
is missing) when installing from a branch. Can add prepare
to package.json
to make testing a branch easier: https://blog.jim-nielsen.com/2018/installing-and-building-an-npm-package-from-github.
from contacts.
@Idrimi What's the status of this update to support Capacitor 3? Do you want any help with it?
from contacts.
@Idrimi can re-open if he would like, but I've published 1.0.5 of@capacitor-community/contacts
. The code is from the latest develop
branch to npm so it is easier for people to install and use in their projects. To install, use npm i @capacitor-community/contacts@next
from contacts.
Can confirm it's working, thanks @thomasvidas
from contacts.
@kainosnoema yeah, open a PR maybe i can take some inspiration for android support.
from contacts.
@Idrimi only Android actually but I have iOS here also will check in a bit
from contacts.
Confirming that both work, iOS and Android
from contacts.
Actually I do have one problem after an update, when doing npx pod sync
this morning after an update I get update ios - failed! No podspec found for CapacitorCommunityContacts
cc @thomasvidas
from contacts.
After manually adding the podspec iOS works
from contacts.
thx @Yuripetusko for testing. Missing podspec file is fixed.
from contacts.
Thx for testing. i'll have a look at it.
The way you do the import seems right.
Do not know how to migrate Apps to cap 3 properly yet. Had to kill ios plattform completely, then add it again.
This branch here is working: https://github.com/byrdsandbytes/capContactsDemo/tree/develop using a local version of the plugin
doesn't display number type label etc
from contacts.
Related Issues (20)
- iOS image payload assumes that Base64 is always a png. HOT 3
- feat: add ability to pick multiple contacts HOT 2
- Upgrade to v5 HOT 7
- Add namespace in build.gradle to fix android compilation issue on Capacitor 5.x.x HOT 1
- iOS Contact Image not cropped HOT 5
- Type definitions for pickContact is wrong HOT 1
- CANCELLED HOT 3
- feat: Add flag for isFavorite
- How to open a contact with default contact app after creating a contact
- Add thumbnailImage projection HOT 3
- ANR android crash HOT 2
- feat: Capacitor 6 Support HOT 17
- Feat: Do not require android.permission.WRITE_CONTACTS HOT 2
- Feat: Add nickname to name result type
- Contact fields duplicating in strange ways on Android HOT 1
- checkPermissions doesn't give back a response on iOS HOT 2
- projection is returning more fields than expected HOT 2
- projection with image crashes the App on iOS HOT 1
- SaveContact HOT 1
- getObject calls without a default value will return null in Capacitor 5 instead of an empty object to match iOS behavior
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contacts.