Git Product home page Git Product logo

Comments (4)

ljharb avatar ljharb commented on August 20, 2024

Can you provide a http://jsfiddle.net/ with an example? in lib/widgets.js, it already uses the id if available, and constructs one from the name if not.

from forms.

tylkomat avatar tylkomat commented on August 20, 2024

In lib/render.js the field.labelHTML(name) is just called with name, while in /lib/fields.js the function is defined with name and id parameter. Since it just called with name, it can also just build the for attribute with name.

from forms.

tylkomat avatar tylkomat commented on August 20, 2024

There are 2 options either field.id can be added as second parameter to each field.labelHTML call in lib/render.js or lib/fields.js can be changed to take the values from the field itself, since the function belongs to the field and can access the values anyway. Might be also possible to remove name parameter also.

from forms.

ljharb avatar ljharb commented on August 20, 2024

There's two calls to labelHTML in that file - one has "name, id" and the second has just "name". The simple fix is to pass the ID in the second call. The name is required to construct the ID if it's not present.

from forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.