`ingress_changed` event is emitted 3 times and the first one with `None` about traefik-k8s-operator HOT 5 OPEN

When you remove the ingress relation, it must be able to tell you that you no longer have that URL available, and that is what None is for, which the requirer charm must read as "I have no (longer?) an ingress URL". We could probably change it so that, if the relation is established (relation_created and relation_joined), the event does not fire in the requirer until you have an URL, but given #28 in flight, I think we need to see how that affects the behavior first.

from traefik-k8s-operator.

In spite of the fact that this is a great example to discuss if we should condense 2 situations (add a relation and remove a relation) in only one custom event (ingress_changed), the problem I see is that we are emitting not one, but three events when a relation is created.
As you said, maybe we can avoid emitting the event until we have an URL. But if we do that, we are still emitting two events with the same information.

from traefik-k8s-operator.

The reason to have one event, is that most charms I can think off, will react to it the same way: "Got some configs to change". Having multiple events that are reacted to the same way, seems like unnecessary complication to me.

from traefik-k8s-operator.

For example: Grafana, Prometheus and Alertmanager, likely even Loki: they mostly need to change a parameter that sets their externally visible URL. The value to set changes on whether you get an ingress URL or not, but the logic is 95% the same.

from traefik-k8s-operator.

For example: Grafana, Prometheus and Alertmanager, likely even Loki: they mostly need to change a parameter that sets their externally visible URL. The value to set changes on whether you get an ingress URL or not, but the logic is 95% the same.

from traefik-k8s-operator.