Loki push_api lib should validate alert rules have at least one equality matcher about loki-k8s-operator HOT 9 CLOSED

Any rules without equality matchers should do. I think I was using this one:

alert: CPUOverUse
expr: process_cpu_seconds_total > 0.12
for: 0m
labels:
  severity: Low
annotations:
  summary: "Instance {{ $labels.instance }} CPU over use"
  description: "{{ $labels.instance }} of job {{ $labels.job }} has used too much CPU."

from loki-k8s-operator.

@rbarry82 do you mind submitting that / to _ replacement fix?
ok I see it's just because loki wasn't pushed yet since the fix

Revision    Version    Created at    Status
13          13         2022-01-28    released

from loki-k8s-operator.

@dstathis Probably should be pushed to avoid the path nested from units

from loki-k8s-operator.

Hi @sed-i

When I replaced the rule with the following, Loki was happy

groups:
 - name: example
   rules:
     - alert: HighThroughputLogStreams
       expr: absent_over_time({namespace="dev",job=~".*-logs"}[2m])
       for: 2m

Do you have a previous alert rule example that fails?

from loki-k8s-operator.

Any rules without equality matchers should do. I think I was using this one:

alert: CPUOverUse
expr: process_cpu_seconds_total > 0.12
for: 0m
labels:
  severity: Low
annotations:
  summary: "Instance {{ $labels.instance }} CPU over use"
  description: "{{ $labels.instance }} of job {{ $labels.job }} has used too much CPU."

If the expression is: expr: process_cpu_seconds_total >= 0.12 or expr: process_cpu_seconds_total = 0.12 I get the same error... Seems it is not only the equality matcher... I'm asking in #Loki slack channel to understand if it's a Loki bug.

from loki-k8s-operator.

I guess the obvious answer for us is to use the cortex/prometheus validator.

from loki-k8s-operator.

I guess the obvious answer for us is to use the cortex/prometheus validator.

I think we have something interesting: https://github.com/grafana/cortex-tools#rules-lint

from loki-k8s-operator.

From the docs:

The linter's aim is not to verify correctness

from loki-k8s-operator.

The linter's aim is not to verify correctness but just YAML and PromQL expression formatting within the rule file.

We do not want to check the correctness of the expression in terms of it is going to retrieve valid/relevant data. We want to check if it is syntactically valid. Anyway we need to check it,

This issue started because the was no "=" in the expression.

from loki-k8s-operator.