Git Product home page Git Product logo

Comments (6)

rbarry82 avatar rbarry82 commented on July 4, 2024 1

I expect that it fell out of sync due to the publish-to-edge action failing. I synced and it's published and up to date as 16 now

from cos-configuration-k8s-operator.

sed-i avatar sed-i commented on July 4, 2024

Hmm. Looking at canonical/grafana-k8s-operator#116

from cos-configuration-k8s-operator.

sed-i avatar sed-i commented on July 4, 2024

@rbarry82 how would you recommend going about inject_dropdowns=False for cos-config?
Keep dashboards_path as-is but then, on relation-changed, call add_dashboard(inject_dropdowns=False) for all files?
How about adding inject_dropdowns=True to the GrafanaDashboardProvider constructor's kwargs?

from cos-configuration-k8s-operator.

rbarry82 avatar rbarry82 commented on July 4, 2024

It was added to _reinitialize_dashboard_data because that is the explicit backdoor used by cos-config. I would somewhat expect cos_config to add the argument there rather than polluting the constructor with another arg which is only used "globally" by a single charm, maintained by our own team

from cos-configuration-k8s-operator.

sed-i avatar sed-i commented on July 4, 2024

Ah yes, _reinitialize_dashboard_data. Thanks!

from cos-configuration-k8s-operator.

sed-i avatar sed-i commented on July 4, 2024

@rbarry, shall we publish-lib grafana-dashboard? On charmhub it's LIBPATCH 13 (before inject_dropdowns) vs 16 in main.

from cos-configuration-k8s-operator.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.