Comments (6)
hanw
commented on August 10, 2024
Hi threonorm, Jamey is on vacation with limited email access, so your question may not be answered in time. It sounds like the error is due to some hacky-ness in bsvdependencies.py , would you be able suggest a fix for this? I think you are correct that none of these two cases should generate a dependency.
from connectal.
threonorm
commented on August 10, 2024
Hi hanw, thanks for your answer!
I have a "fix" where I just consider every commented dependency to be not a dependency, this work for my use of the bsvdependencies functions, but I suspect that Jamey uses it in a different way somewhere else where he actually wants to keep this feature. (The way the code is written make me believe that this is really a feature)
For this reason, I don't want to pull request yet, waiting for his opinion is definitely a good idea :).
from connectal.
jameyhicks
commented on August 10, 2024
I guess it would be less Jaclyn if bsvpreprocess returned a list of included files as well as the expanded source code. Do you have time to make that change? Then it could ignore all commented out includes.
from connectal.
jameyhicks
commented on August 10, 2024
autocorrect strikes again :)
from connectal.
jameyhicks
commented on August 10, 2024
In case you did not see the comments I made in one of the chat channels:
I think this is an artifact of the interaction between bsvpreprocess and
bsvdepend. It's a bit too hackish, now, so probably it would be better if
bsvpreprocess returned a list of the included files along with the
preprocessed text and then we do not have to treat commented out includes
specially.
Either that, or we need a much more unique tag for the commented includes.
How about a commented out attribute?
// (* included_file="filename.bsvi" *)
It's too bad the BSV compiler does not support the equivalent of C/C++
#line directive, which is used for just this purpose.
If you have a chance to make a pull request along either of these lines I
would greatly appreciate it.
Happy holidays!
…On Fri, Dec 2, 2016 at 3:03 PM threonorm ***@***.***> wrote:
Hi hanw, thanks for your answer!
I have a "fix" where I just consider every commented dependency to be not
a dependency, this work for my use of the bsvdependencies functions, but I
suspect that Jamey uses it in a different way somewhere else where he
actually wants to keep this feature. (The way the code is written make me
believe that this is really a feature)
For this reason, I don't want to pull request yet, waiting for his opinion
is definitely a good idea :).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACU3s-ktGy7VqAi3VAL82uMkgZU-4Kluks5rEHmjgaJpZM4LC4WU>
.
from connectal.
threonorm
commented on August 10, 2024
Hello Jamey,
I am not sure I understand the problem properly : I don't understand what is
this special kind of include for and where/what it used for. (What are those include that are commented, but still considered as include?)
Though if abstractly speaking you just need a special kind of include, only
seen by connectal build system, and added by connectal automatically somehow, I
think I agree with your second suggestion, I can modify bsvdependencies to
special pick something like //CONNECTALINCLUDE "nameoffile"
I can definitely make the one line change in bsvdependencies, but I would
break everything by doing so, because I don't know where I should change
things as well. (I guess some script add those special include for connectal
somewhere : I think those special include are not hand written, are they ? And
if they are, it means that I will break every project that is using them.).
Thomas
Excerpts from Jamey Hicks's message of 2016-12-30 08:10:02 -0500:
… In case you did not see the comments I made in one of the chat channels:
I think this is an artifact of the interaction between bsvpreprocess and
bsvdepend. It's a bit too hackish, now, so probably it would be better if
bsvpreprocess returned a list of the included files along with the
preprocessed text and then we do not have to treat commented out includes
specially.
Either that, or we need a much more unique tag for the commented includes.
How about a commented out attribute?
// (* included_file="filename.bsvi" *)
It's too bad the BSV compiler does not support the equivalent of C/C++
#line directive, which is used for just this purpose.
If you have a chance to make a pull request along either of these lines I
would greatly appreciate it.
Happy holidays!
On Fri, Dec 2, 2016 at 3:03 PM threonorm ***@***.***> wrote:
> Hi hanw, thanks for your answer!
>
> I have a "fix" where I just consider every commented dependency to be not
> a dependency, this work for my use of the bsvdependencies functions, but I
> suspect that Jamey uses it in a different way somewhere else where he
> actually wants to keep this feature. (The way the code is written make me
> believe that this is really a feature)
>
> For this reason, I don't want to pull request yet, waiting for his opinion
> is definitely a good idea :).
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#132 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACU3s-ktGy7VqAi3VAL82uMkgZU-4Kluks5rEHmjgaJpZM4LC4WU>
> .
>
from connectal.
Related Issues (20)
- Adding Connectal Support to DE5 Net Board HOT 4
- Connectal Support for open source bsc compiler HOT 10
- Bypass version mismatch problems in generated Makefile HOT 1
- Simple Amazon AWS EC2 F1 example HOT 16
- Documentation embedded diagrams HOT 3
- write documentation for bsvdepend.py
- Is it possible to support the opensource bsc? HOT 5
- bsvdepend.py fails to find imported package whose name is expanded from macro
- AWS build script should check for credentials before starting the build
- Python 3 support HOT 4
- PCIe drivers fail to compile on Ubuntu 16.04 HOT 3
- PcieHost.bsv fails to build for multiple targets HOT 11
- DataBusWidth=256 support HOT 8
- Error in pcieportal_ioctl function HOT 5
- Error while building for kc705, "recipe for target 'obj/Pcie1EndpointX7.bo' failed" HOT 4
- error while running "make run.kc705g2" HOT 9
- ERROR: could not insert 'portalmem' HOT 2
- support the bitwidth calculation of decimal number scoped enumeration HOT 5
- Problem while building for zedboard HOT 2
- obsolete bsc version checking bug in `scripts/Makefile.connectal.build` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connectal.