Git Product home page Git Product logo

Comments (7)

calzoneman avatar calzoneman commented on August 20, 2024

from sync.

mopoIo avatar mopoIo commented on August 20, 2024

Ohh it's the send button that comes by default with sync after you enable it from settings, I just changed the format of it, is there a way to make it visible by default?

from sync.

calzoneman avatar calzoneman commented on August 20, 2024

If you mean the "Add a send button to chat" setting, I actually had forgotten that existed, if I remember correctly that was a workaround for ancient mobile browsers (that almost certainly no longer exist) which lacked the ability to press Enter on the virtual keyboard to send the message. It really shouldn't need to be used by anyone anymore.

With that said, it is currently implemented as a user setting, which means that if you would like the button to be displayed, you can enable the setting for yourself, otherwise, you can leave it off (when you click save in the settings, it should preserve across reloads at least within the same browser session). You shouldn't try to control how other users choose to view the page; if another user decides that they think the button belongs there they can enable the setting for themselves.

from sync.

calzoneman avatar calzoneman commented on August 20, 2024

As I suspected, this was a hack for ancient mobile browsers: #127

from sync.

mopoIo avatar mopoIo commented on August 20, 2024

Thank you for the reply. I understand how having the option there is useful, but on my design it looks better with the button there since the rest of the css was coded for the button to be visible. I understand your reasoning and how it's not worth putting the time on a per-case scenario and it's best to look at the bigger picture. Do you think there's a workaround to make the button visible by default or is forking the website the only way? Again, thank you for the replies.

from sync.

calzoneman avatar calzoneman commented on August 20, 2024

If your CSS looks out of place when users are using default settings, then I would suggest fixing your CSS instead of trying to override user settings. I can't really advise on a way to do the latter because I've never tried to do it, sorry.

from sync.

mopoIo avatar mopoIo commented on August 20, 2024

Yeah looks out of place cause the design is made for the button to be visible since it looks better that way, I appreciate your time, I'll go ahead and close this. Cheers

from sync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.