Comments (5)
mhucka
commented on June 3, 2024
Thanks for this report. I'll take a look at the relevant parts and test with multibyte characters. This comes at a good time as I'm working on DIBS currently.
from dibs.
stanonik
commented on June 3, 2024
Hi,
Thanks for the reply.
We found the following seems to work for us.
This wasn't the result of careful code reading, rather just a quick glimpse
to solve, first the open, then a length problem.
Anyway, thanks for the code.
Ron Stanonik
…--- a/dibs/server.py
+++ b/dibs/server.py
@@ -720,10 +720,10 @@ def return_iiif_manifest(barcode, person):
log(f'{manifest_file} does not exist')
return
record_request(barcode)
- with open(manifest_file, 'r') as mf:
+ with open(manifest_file, 'r', encoding='utf-8') as mf:
adjusted_content = urls_rerouted(mf.read(), barcode)
data = BytesIO(adjusted_content.encode())
- size = len(adjusted_content)
+ size = len(adjusted_content.encode())
log(f'returning manifest for {barcode} for
{anon(person.uname)}')
return send_file(data, ctype = 'application/json', size = size)
else:
On Fri, Sep 10, 2021 at 8:22 PM Mike Hucka ***@***.***> wrote:
Thanks for this report. I'll take a look at the relevant parts and test
with multibyte characters. This comes at a good time as I'm working on DIBS
currently.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6U4J434ODCNHAMD7BQOADUBLDONANCNFSM5DZS7C2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from dibs.
mhucka
commented on June 3, 2024
This is in commit f098ce6.
from dibs.
mhucka
commented on June 3, 2024
@stanonik I'm having trouble finding a manifest file that I could use for testing this issue. I don't suppose you have something that you could share? Even if the IIIF URLs didn't work in our site, it would still make it possible to try reading the file and trying to understand if other problems might still exist. If you don't want to upload it here but could share it privately, perhaps email it to me directly to [email protected]?
from dibs.
mhucka
commented on June 3, 2024
Thanks for the example manifest file. Things seem to be working with that change, so I'm going ahead and closing this issue, but if necessary we can reopen it.
from dibs.
Related Issues (20)
- Provide way to bulk-update permalinks HOT 1
- Editing item fails to update item link HOT 1
- Changing item barcode when editing item fails to update all item fields HOT 1
- Remind staff about potential issue when reducing number of copies available for loans.
- Wrong number of args to `log` function call in server.py line 495 HOT 1
- Report permission errors better HOT 1
- Improve codemeta.json file
- Make barcodes strings rather than ints
- Anonymize names printed in logs HOT 1
- Add a notes field HOT 1
- Provide a way to save and reload data HOT 1
- Report additional statistics HOT 1
- /item-status log messages contain email address HOT 1
- Save book cover images instead of linking to them HOT 1
- Don't hardcode tind url in server.py HOT 1
- Wrong default for process directory in server.py HOT 1
- filesystem lag? Process button appears again HOT 1
- Incomplete LSP records should not result in error "no such item found" HOT 1
- Can't view item when client timezone is greater than loan window HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dibs.