Branches Does not preserve order about partial.lenses HOT 2 OPEN

Thanks! Just to recap, the current documentation says that

L.branches(p1, ..., pN) is equivalent to L.branch({[p1]: [], ..., [pN]: []})

which means that the keys are examined in object key order. The proposal is to change the order to match the order of the arguments instead.

🤔

Yeah, I think that change makes sense. It does likely require a bit more code to build the map and it is technically a breaking change, but unlikely to affect most users.

Did you run into a problem due to this?

I could imagine e.g. one using L.forEach with L.branches and being surprised due to the traversal order.

from partial.lenses.

@polytypic - I was using branches along with a disperse, I had a collection of ids to update.

L.branches(...formIds) the formIds were strings of numbers for example: ['1256', '9807', '123'].

Then I would use L.disperse(myBranchesTraversal, [1,2,3], {}); I guess this is another instance of JS behavior being a bit unexpected. As, when the string keys are put into an object they are sorted and then traversed in that order.

Another option may be to create another orderedBranches that maintains the argument or array order as opposed to the object key order, that way it wouldn't break any users that are relying on the object key order.

Thanks for the quick response by the way!

from partial.lenses.