Git Product home page Git Product logo

Comments (1)

jordangrant avatar jordangrant commented on July 24, 2024

For others that run into this. I really needed PNGs to maintain their transparency and this cropper was causing me to lose transparency.

#44
I was getting nothing back for:

NSString *urlPath = [url path];
NSString *extension = [urlPath pathExtension];

and the url of the

NSURL *url = [imageRequest URL];
NSString *urlstring = url.absoluteString;

was rct-image-store://0
So it always defaulted to JPG.

I decided to force PNG. ->>>> Meaning I removed:

if([extension isEqualToString:@"png"]){
} else {
} 

in iOS/RNCImageEditor.m and user the png logic only
I question if #44 ever worked.

Now, my complete solution - I detect the image type (uri includes jpg, png) before passing it to the cropper, crop it and force png, then resave it with the appropriate extension to the app ~/Documents folder.

 function cropperDone(croppedImageUri) {
        let filetype = imageBeforeCrop.includes('png') ? 'png' : 'jpg';

        helpers.saveImageToDocuments(croppedImageUri, filetype).then((uri) => {
            // Continue
        });
    }

from react-native-image-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.