[iOS] Don't use ImageStore about react-native-image-editor HOT 18 CLOSED

Any updates on this? ImageEditor is still saving to a location where RNFS cannot read. This should be solved before ImageStore is not supported entirely.

from react-native-image-editor.

@benzman81 Once #29 lands on master, I'll release new major version, but yeah, for now this should be reopened

from react-native-image-editor.

Hi @guhungry Thanks for creating issue and yes, we need to migrate from using ImageStoreManager.

@cpojer Do you have any recommendations, which package should we use?

from react-native-image-editor.

@Trancever There is no need for 3rd party package. This can easily implemented in native code as in Potential Implementation.

from react-native-image-editor.

@guhungry @kevinwu127 Check v1.4.0 and let me know what you think!

from react-native-image-editor.

I'll test it tonight and report back. But i think this this is breaking change for ios?

from react-native-image-editor.

@guhungry I haven't thought about it as breaking change, but It makes sense, since there is no need to clear the image right now.
I'll remove that v1.4 release from both npm and github tomorrow and I'll do new major release then.

from react-native-image-editor.

It does work as expect. Major version make sense to me.

@Trancever What do you think about using promise instead of callback?

from react-native-image-editor.

@guhungry I am ok with Promises, especially right now when we are releasing new major version

from react-native-image-editor.

@Trancever Works great! Looking forward to the Promise implementation :)

from react-native-image-editor.

Since you reverted the version and the ImageStore is still used, shouldn't you reopen this issue?

from react-native-image-editor.

@benzman81 @kevinwu127 Can you help test with #29 which also includes this PR and Promise implementation?

from react-native-image-editor.

@guhungry the PR looks good! Thank you for this :)

from react-native-image-editor.

I've just released version 2.0.0-alpha.0 that contains new way of storing images on iOS + Promise api. Could you guys test it and let me know if it works well for you?

from react-native-image-editor.

Works for me.

Screenshots

Android: iOS:

from react-native-image-editor.

Sorry for the delay. v2.0.0-alpha.0 works like a charm.

from react-native-image-editor.

@benzman81 @guhungry Awesome, I'll release a non alpha version this week.

from react-native-image-editor.

v2.0.0 is released.

from react-native-image-editor.