Comments (6)
I’m just taking a wild guess the "main": "dist/jump.min.js"
in the package.json
is what’s npm is using to decide which file to use? I vote +1 to change it to the non-minified file.
from jump.js.
Correct, that's what npm is using to decide on the minified file. I think this requires a small code change to change the build script to not minify, but I'm not 100% sure.
from jump.js.
@vincentorback @saarons makes sense, since people using this from NPM must be using a module bundler and are likely minifying their build anyways. I want to support ES6 practices and workflow above all else, and I think this suggestion is in line with that.
the relevant line of the gulpfile
is here. removing that will keep the dist
file from being minified. if it's not minified, it would also be wise to rename it, removing the .min
.
this weekend, i'm planning on un-minifying all my dist
files, for all my libraries, as well as adding the jsnext:main
field to all my package.json
s, to support future-facing tree-shaking module bundlers like rollup
from jump.js.
Will this be implemented any time soon?
from jump.js.
For those waiting, Sitepoint offers a ES5 version in an article about this lib. Don't know the diff to the last version, but seems to work and includes an accessibility bugfix as a bonus. http://www.sitepoint.com/smooth-scrolling-vanilla-javascript/
(Note: I'm not affiliated with them, just thought it is worth pointing out while this case is open)
from jump.js.
please see #31, and leave your feedback!
from jump.js.
Related Issues (20)
- Function not found due to wrong path HOT 8
- No module export HOT 3
- It is a nightmare to use this with my angular 2 application using system js for bundling HOT 1
- Sometimes callback executing before scrolling has finished HOT 1
- prevent calling jump() when current jump is not finished
- Is it possible to use Jump to replace the default behavior for the anchors? HOT 1
- Feature Request: Make target optional HOT 1
- Document why tabindex is necessary when a11y: true HOT 4
- Option to prevent anchor from beeing added to the URL? HOT 1
- Error in case of jumping to non-existing target HOT 1
- Bug in Chrome With Small Viewports -- Jump Effect with Flicker and Ignoring Offset HOT 2
- Scrolling Breaks When CSS Has Overflow. HOT 1
- Prevent jumping when position is the same
- MIT Licence not assigned on GH HOT 1
- Can we use GSAP Easings with Jump.js ? HOT 2
- Doesn't work with gulp? HOT 1
- Help needed with angular
- An old scholl version, really.. HOT 2
- Can't scroll back up the page
- Lazy loading images
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jump.js.