Git Product home page Git Product logo

Comments (6)

vincentorback avatar vincentorback commented on May 20, 2024

I’m just taking a wild guess the "main": "dist/jump.min.js" in the package.json is what’s npm is using to decide which file to use? I vote +1 to change it to the non-minified file.

from jump.js.

saarons avatar saarons commented on May 20, 2024

Correct, that's what npm is using to decide on the minified file. I think this requires a small code change to change the build script to not minify, but I'm not 100% sure.

from jump.js.

callmecavs avatar callmecavs commented on May 20, 2024

@vincentorback @saarons makes sense, since people using this from NPM must be using a module bundler and are likely minifying their build anyways. I want to support ES6 practices and workflow above all else, and I think this suggestion is in line with that.

the relevant line of the gulpfile is here. removing that will keep the dist file from being minified. if it's not minified, it would also be wise to rename it, removing the .min.

this weekend, i'm planning on un-minifying all my dist files, for all my libraries, as well as adding the jsnext:main field to all my package.jsons, to support future-facing tree-shaking module bundlers like rollup

from jump.js.

cattermo avatar cattermo commented on May 20, 2024

Will this be implemented any time soon?

from jump.js.

renzo-s avatar renzo-s commented on May 20, 2024

For those waiting, Sitepoint offers a ES5 version in an article about this lib. Don't know the diff to the last version, but seems to work and includes an accessibility bugfix as a bonus. http://www.sitepoint.com/smooth-scrolling-vanilla-javascript/

(Note: I'm not affiliated with them, just thought it is worth pointing out while this case is open)

from jump.js.

callmecavs avatar callmecavs commented on May 20, 2024

please see #31, and leave your feedback!

from jump.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.