Comments (7)
@antonis: The window.Intercom
is not a function error can be worked around. In most places where you're doing window.Intercom
, you actually want to do window['Intercom']
(which is the same thing, but it won't piss off the typescript compiler). The other issue with unit tests for this package is going to involve creating a mock class to use in your unit tests and provide that with the ngintercom module. That should fix it. I went back to using the regular intercom code over this since it doesn't seem to be maintained (for what it's worth).
from ng-intercom.
i didn’t know this was an issue. i can write a mock and build it in so you don’t have to.
from ng-intercom.
Thanks, @wbhob. Let me know if you need an example repo to reproduce the errors.
from ng-intercom.
Upgraded to angular 6 and [email protected] now my unit test are failing as well. Im getting an window.Intercom is not a function
error .
from ng-intercom.
@mswilson4040 we are always looking for help maintaining! Devs all working together to not have to repeat stuff is why we published this repo. Thank you for your input!
from ng-intercom.
We are still maintaining this module, but have not had time to make any big changes. It has been relatively stable in our tests and in the community, but nonetheless we are hesitant to publish a full release (not beta- tagged).
from ng-intercom.
@AntonisFK this is fixed in #67 @mswilson4040 can you share a repo so I can finish up those mocks
from ng-intercom.
Related Issues (20)
- Error starting tour HOT 1
- Intercom is not compatible with Angular 9 since .forRoot() got deprecated. HOT 3
- Angular 11 is incompatible HOT 3
- Not showing Intercom(icon widget) before login
- Upgrade to Angular v16 HOT 7
- Breaks under Angular 17 HOT 1
- appId being ignored in boot method HOT 3
- Function calls are not supported in decorators but 'IntercomModule' was called. - Regression in beta.6 HOT 38
- Support for angular 7.0 HOT 2
- Event metadata must be an object HOT 1
- Problems when building HOT 4
- Error with ng build --prod HOT 2
- Function calls are not supported in decorators but 'IntercomModule' was called. HOT 1
- Provider parse errors, Cannot instantiate cyclic dependency HOT 2
- Please ensure your intercomSettings object is formatted correctly: Missing App ID. HOT 8
- [fix] use window.intercomSettings to initiate app ID
- Lib broken in 8.0.0-rc.0 HOT 1
- Star tour function needed HOT 8
- Route performance problems using updateOnRouterChange HOT 5
- [8.0.1] Cannot find module 'ng-intercom' HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ng-intercom.