Git Product home page Git Product logo

Comments (7)

marc-wilson avatar marc-wilson commented on September 16, 2024 2

@antonis: The window.Intercom is not a function error can be worked around. In most places where you're doing window.Intercom, you actually want to do window['Intercom'] (which is the same thing, but it won't piss off the typescript compiler). The other issue with unit tests for this package is going to involve creating a mock class to use in your unit tests and provide that with the ngintercom module. That should fix it. I went back to using the regular intercom code over this since it doesn't seem to be maintained (for what it's worth).

from ng-intercom.

wbhob avatar wbhob commented on September 16, 2024

i didn’t know this was an issue. i can write a mock and build it in so you don’t have to.

from ng-intercom.

marc-wilson avatar marc-wilson commented on September 16, 2024

Thanks, @wbhob. Let me know if you need an example repo to reproduce the errors.

from ng-intercom.

AntonisFK avatar AntonisFK commented on September 16, 2024

Upgraded to angular 6 and [email protected] now my unit test are failing as well. Im getting an window.Intercom is not a function error .

from ng-intercom.

scott-wyatt avatar scott-wyatt commented on September 16, 2024

@mswilson4040 we are always looking for help maintaining! Devs all working together to not have to repeat stuff is why we published this repo. Thank you for your input!

from ng-intercom.

wbhob avatar wbhob commented on September 16, 2024

We are still maintaining this module, but have not had time to make any big changes. It has been relatively stable in our tests and in the community, but nonetheless we are hesitant to publish a full release (not beta- tagged).

from ng-intercom.

wbhob avatar wbhob commented on September 16, 2024

@AntonisFK this is fixed in #67 @mswilson4040 can you share a repo so I can finish up those mocks

from ng-intercom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.